<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124327/">https://git.reviewboard.kde.org/r/124327/</a>
     </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>


<p style="color: grey;"><i>Updated July 26, 2015, 11:27 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit a19e608a2b3ad87ce5fe6c51b548459daf3ad7a1 by Mikhail Ivchenko on behalf of Gábor Péterffy to branch master.</pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds a search bar to Marble Maps. Because the loading of the plugins not works on Android, the search function is not working.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On linux it works fine when the runner plugins are loaded. On Android the UI appears fine but not working with loaded plugins.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>data/android/pixmaps/searchFocused.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/android/pixmaps/searchPressed.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/android/pixmaps/searchReleased.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/MainScreen.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/MarbleMaps.qrc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/QmlView.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/QmlView.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/SearchBar.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/SearchBarBackend.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/SearchBarBackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/MarblePlacemarkModel.cpp <span style="color: grey">(a2c78c4f8603752182f64e42e02a585d5ea6b2e3)</span></li>

 <li>src/lib/marble/MarbleQuickItem.h <span style="color: grey">(41e20bb69bbeb9c1d662cd943ecb13674fd04498)</span></li>

 <li>src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp <span style="color: grey">(7c1803998ce5a01e338f2eb04a2b7f310a926c26)</span></li>

 <li>src/plugins/runner/yours/YoursRunner.cpp <span style="color: grey">(4b1c0552718acc4a2f3070e95950975a57d4fdd4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124327/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/95493cb2-c43c-48f4-a1f0-7a5ca0486856__Screenshot_2015-07-13-17-57-06.png">Screenshot</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/ab43529f-26f4-4f52-9ba5-1c759fcee07d__Screenshot_2015-07-13-17-56-45.png">Screenshot 2</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/b6c76a6b-9118-4841-97e7-c204567454b8__Screenshot_2015-07-13-17-40-46.png">Screenshot 3</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/4fc5e41a-40aa-4d62-879c-6436e93dd1a0__searchFocused.png">searchFocused.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/c16c83c4-d25f-482d-b409-7cece2f7bad0__searchPressed.png">searchPressed.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/58b3d964-641d-457f-911e-62066d55cf61__searchReleased.png">searchReleased.png</a></li>

</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>