<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124466/">https://git.reviewboard.kde.org/r/124466/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works fine on a Nexus 4 also.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding the startup time: This happens as much more plugins are compiled on Android now. I plan to rework the package creation a bit next to allow certain files (plugins, data components) which are not needed to be excluded from the package.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124466/diff/1/?file=387680#file387680line1" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble-maps/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set</span><span class="p">(</span><span class="s">marble_SRCS</span> <span class="s">main.cpp</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set</span><span class="p">(</span><span class="s">marble_SRCS</span> <span class="s">main.cpp</span><span class="hl"> </span><span class="s"><span class="hl">SearchBackend.cpp</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you add the new .qml files to the custom target so that IDEs like QtCreator show them in the project tree?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #000080; font-weight: bold">diff --git a/src/apps/marble-maps/CMakeLists.txt b/src/apps/marble-maps/CMakeLists.txt</span>
<span style="color: #000080; font-weight: bold">index 380bbf3..c7c1437 100644</span>
<span style="color: #A00000">--- a/src/apps/marble-maps/CMakeLists.txt</span>
<span style="color: #00A000">+++ b/src/apps/marble-maps/CMakeLists.txt</span>
<span style="color: #800080; font-weight: bold">@@ -29,7 +29,8 @@ file(COPY "../../../data/android/drawable-xhdpi" DESTINATION "${CMAKE_BINARY_DIR</span>
file(COPY "../../../data/android/drawable-xxhdpi" DESTINATION "${CMAKE_BINARY_DIR}/src/apps/marble-maps/res")
file(COPY "../../../data/android/drawable-xxxhdpi" DESTINATION "${CMAKE_BINARY_DIR}/src/apps/marble-maps/res")
<span style="color: #A00000">-add_custom_target(marble-maps_resources ALL SOURCES MainScreen.qml package/AndroidManifest.xml)</span>
<span style="color: #00A000">+FILE (GLOB QML_FILES *.qml)</span>
<span style="color: #00A000">+add_custom_target(marble-maps_resources ALL SOURCES ${QML_FILES} package/AndroidManifest.xml)</span>
if (ANDROID)
include("$ENV{Qt5_android_cmake}/AddQtAndroidApk.cmake")
</pre></div>
</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124466/diff/1/?file=387681#file387681line18" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble-maps/MainScreen.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">onTriggered:</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I wonder if we should use properties instead of functions, see below.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124466/diff/1/?file=387682#file387682line8" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble-maps/MarbleMaps.qrc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">8</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <file alias="search.png">../../../data/android/drawable-xxxhdpi/search.png</file></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We should add the usage of Android material icons to our about / credit dialog. It doesn't exist yet for Android, so let's ignore it for now, but work on it soon.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124466/diff/1/?file=387683#file387683line14" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble-maps/Search.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kd">function</span> <span class="nx">showBar</span><span class="p">()</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Visibility changes propagate to children, so we could simplify it like this: https://paste.kde.org/pnhzu51b8</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124466/diff/1/?file=387685#file387685line73" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble-maps/SearchBackend.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="n">m_searchManager</span> <span class="o">!=</span> <span class="k">nullptr</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The check is not needed, calling delete on a nullptr is perfectly fine.</p></pre>
</div>
</div>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On July 25th, 2015, 9:08 p.m. UTC, Mihail Ivchenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Gábor Péterffy.</div>
<div>By Mihail Ivchenko.</div>
<p style="color: grey;"><i>Updated July 25, 2015, 9:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Based on <a href="https://git.reviewboard.kde.org/r/124327/" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">work of Gábor Péterffy</a></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works well on Nexus 5 & Nexus 9 (both are Android 5.1.1).
Only issue I noticed:
After starting UI doesn't for few sec (looks like because of plugins loading). But that issue wasn't caused by this patch but previous one.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/android/drawable-xxxhdpi/search.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/CMakeLists.txt <span style="color: grey">(ea6ca1e)</span></li>
<li>src/apps/marble-maps/MainScreen.qml <span style="color: grey">(8f50962)</span></li>
<li>src/apps/marble-maps/MarbleMaps.qrc <span style="color: grey">(6bb2336)</span></li>
<li>src/apps/marble-maps/Search.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/SearchBackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/SearchBackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/SearchField.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/SearchResults.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/Theme.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/main.cpp <span style="color: grey">(08f4be5)</span></li>
<li>src/lib/marble/MarblePlacemarkModel.cpp <span style="color: grey">(b814fdb)</span></li>
<li>src/lib/marble/MarbleQuickItem.h <span style="color: grey">(fa61707)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124466/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/e875539c-62ec-4b71-a49c-20f477187eed__search.png">search.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/835ab63a-aca5-4efa-a868-601b8b15f70e__Screenshot_2015-07-26-00-42-05.png">Screenshot_2015-07-26-00-42-05.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/977187a9-0fc3-43bf-b050-d819476c2afb__Screenshot_2015-07-26-00-42-15.png">Screenshot_2015-07-26-00-42-15.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/357df10d-5170-4e58-808f-6fece05327f6__Screenshot_2015-07-26-00-42-28.png">Screenshot_2015-07-26-00-42-28.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/ce250cea-47e9-4829-b705-370daf431742__Screenshot_2015-07-26-00-42-50.png">Screenshot_2015-07-26-00-42-50.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/25/e5ebe15e-b394-42ce-a2d1-ba729cf00780__Screenshot_2015-07-26-00-43-05.png">Screenshot_2015-07-26-00-43-05.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>