<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124441/">https://git.reviewboard.kde.org/r/124441/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Gábor Péterffy.</div>
<div>By Mihail Ivchenko.</div>
<p style="color: grey;"><i>Updated July 24, 2015, 11:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix style mistakes and disable fullsceen.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Move Marble Maps to QQmlApplicationEngine and QtQuick components.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add basic menubar and toolbar. Use "Holo Dark" Android theme.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works on Nexus 5 & Nexus 9 (both Android 5.1.1).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Noticed issues:
- After clicking on menu navbar appears (see screenshot) and it doesn't hide. I tried to add simple TextField and after: 1) clicking on it; 2) closing keyboard; navbar hides. So, looks it's something focus-related.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, do we even need to go to fullscreen (immersive mode)? For example Google Earth and Google Maps doesn't use it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble_maps/CMakeLists.txt <span style="color: grey">(a259af7)</span></li>
<li>src/apps/marble_maps/MainScreen.qml <span style="color: grey">(96238c5)</span></li>
<li>src/apps/marble_maps/QmlView.h <span style="color: grey">(b312d9a)</span></li>
<li>src/apps/marble_maps/QmlView.cpp <span style="color: grey">(6c4fc70)</span></li>
<li>src/apps/marble_maps/main.cpp <span style="color: grey">(473ff44)</span></li>
<li>src/apps/marble_maps/package/AndroidManifest.xml <span style="color: grey">(9125e5d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124441/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/23/8c561590-4e50-47f2-83ab-44b883c4f51c__Holo_Dark_2.png">Holo Dark 2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/23/63c4a2ff-ea1d-47d9-a004-46cc056d7468__Holo_Dark_3.png">Holo Dark 3.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/4c96aaa9-b06e-4cdf-9b8a-09ff9f1daae3__Holo_Dark_non-fullscreen.png">Holo Dark non-fullscreen.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/1fe9f00b-434d-49d2-ae4d-4341b64f13c8__Holo_Dark_non-fullscreen_2.png">Holo Dark non-fullscreen 2.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>