<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124327/">https://git.reviewboard.kde.org/r/124327/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On július 15th, 2015, 10:26 de CEST, <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124327/diff/4/?file=385238#file385238line29" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble_maps/MainScreen.qml</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">SearchBar</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why should the search bar be a child of the MarbleItem - is there any reason? :)</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Because it depends on it, without it it is useless and if we use it in this way, we can set the marble item for the children when we create them, because they just have to ask who is the parent.</p></pre>
<br />
<p>- Gábor</p>
<br />
<p>On július 17th, 2015, 5:21 de CEST, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated júl. 17, 2015, 5:21 de</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds a search bar to Marble Maps. Because the loading of the plugins not works on Android, the search function is not working.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On linux it works fine when the runner plugins are loaded. On Android the UI appears fine but not working with loaded plugins.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/android/pixmaps/searchFocused.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/pixmaps/searchPressed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/pixmaps/searchReleased.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/MainScreen.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/MarbleMaps.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/QmlView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/QmlView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/SearchBar.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/SearchBarBackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/SearchBarBackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarblePlacemarkModel.cpp <span style="color: grey">(a2c78c4f8603752182f64e42e02a585d5ea6b2e3)</span></li>
<li>src/lib/marble/MarbleQuickItem.h <span style="color: grey">(41e20bb69bbeb9c1d662cd943ecb13674fd04498)</span></li>
<li>src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp <span style="color: grey">(7c1803998ce5a01e338f2eb04a2b7f310a926c26)</span></li>
<li>src/plugins/runner/yours/YoursRunner.cpp <span style="color: grey">(4b1c0552718acc4a2f3070e95950975a57d4fdd4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124327/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/95493cb2-c43c-48f4-a1f0-7a5ca0486856__Screenshot_2015-07-13-17-57-06.png">Screenshot</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/ab43529f-26f4-4f52-9ba5-1c759fcee07d__Screenshot_2015-07-13-17-56-45.png">Screenshot 2</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/b6c76a6b-9118-4841-97e7-c204567454b8__Screenshot_2015-07-13-17-40-46.png">Screenshot 3</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>