<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124327/">https://git.reviewboard.kde.org/r/124327/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds a search bar to Marble Maps. Because the loading of the plugins not works on Android, the search function is not working.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On linux it works fine when the runner plugins are loaded. On Android the UI appears fine.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plugins/runner/yours/YoursRunner.cpp <span style="color: grey">(4b1c0552718acc4a2f3070e95950975a57d4fdd4)</span></li>

 <li>src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp <span style="color: grey">(7c1803998ce5a01e338f2eb04a2b7f310a926c26)</span></li>

 <li>src/lib/marble/MarbleQuickItem.h <span style="color: grey">(41e20bb69bbeb9c1d662cd943ecb13674fd04498)</span></li>

 <li>src/apps/marble_maps/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/SearchBarBackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/SearchBarBackend.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/SearchBar.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/QmlView.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/QmlView.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/MarbleMaps.qrc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/MainScreen.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble_maps/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/android/pixmaps/searchUnpressed.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/android/pixmaps/searchPressed.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>data/android/pixmaps/searchFocused.png <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124327/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/11/a670df37-4e21-42c0-880a-5e38ba94cc4b__Screenshot_2015-07-11-13-12-22.png">Screenshot</a></li>

</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>