<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124297/">https://git.reviewboard.kde.org/r/124297/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On július 9th, 2015, 7:47 du CEST, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you please have a look at these patches as well? I think we should commit them asap and base your work on top of them.
https://git.reviewboard.kde.org/r/123291/
https://git.reviewboard.kde.org/r/123202/
https://git.reviewboard.kde.org/r/123204/</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have reviewed them. The first two is okay in my opinion, but I had something to say to the third one. Please view it!</p></pre>
<br />
<p>- Gábor</p>
<br />
<p>On július 8th, 2015, 6:17 du CEST, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated júl. 8, 2015, 6:17 du</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These are added to solve the todo in the example.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> map()->setShowFrameRate(false);
map()->setProjection(Spherical);
map()->setMapThemeId("earth/openstreetmap/openstreetmap.dgml");
map()->setShowAtmosphere(false);
map()->setShowCompass(false);
map()->setShowClouds(false);
map()->setShowCrosshairs(false);
map()->setShowGrid(false);
map()->setShowOverviewMap(false);
map()->setShowOtherPlaces(false);
map()->setShowScaleBar(false);
map()->setShowBackground(false);
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The modification of the example will be in the following patch.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleQuickItem.cpp <span style="color: grey">(94a0a1a498d4be29778f055d6c05bb532f12ee44)</span></li>
<li>src/lib/marble/MarbleQuickItem.h <span style="color: grey">(41e20bb69bbeb9c1d662cd943ecb13674fd04498)</span></li>
<li>src/lib/marble/MarbleGlobal.h <span style="color: grey">(cf2768f16c1427ea7f465391827666261b806b80)</span></li>
<li>src/lib/marble/EnumWrappers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/EnumWrappers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(8b36d0843f585c09c62bf044d0cfb0651a13d4b0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124297/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>