<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124217/">https://git.reviewboard.kde.org/r/124217/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On július 1st, 2015, 7:03 du CEST, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124217/diff/1/?file=381956#file381956line28" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble_maps/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_qt_android_apk</span><span class="p">(</span><span class="s">Marble_apk</span> <span class="s">Marble</span> <span class="s">DEPENDS</span> <span class="s2">"../../../../build/src/lib/marble/libmarblewidget-qt5.so"</span> <span class="s2">"../../../../build/src/lib/astro/libastro.so"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Does adding
NAME "Marble Maps"
have a positive effect?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What effect would have adding
PACKAGE_NAME "org.kde.marble.maps"
have?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It works fine :)</p></pre>
<br />
<p>- Gábor</p>
<br />
<p>On július 1st, 2015, 7:56 du CEST, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated júl. 1, 2015, 7:56 du</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch changed marble_android to marble_maps and also added some stuff what is needed for an app in Google Play. The package name cannot be changed in the manifest to have a working app, because the generated java code uses this package name.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/android/AndroidManifest_MarbleMaps.xml.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-hdpi/marblelogo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-ldpi/marblelogo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-mdpi/marblelogo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xhdpi/marblelogo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxhdpi/marblelogo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/marblelogo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/CMakeLists.txt <span style="color: grey">(2834e13025bf70a202163992e849a92e2801e1cf)</span></li>
<li>src/apps/marble_android/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_android/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_maps/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124217/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>