<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124182/">https://git.reviewboard.kde.org/r/124182/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Ana,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for your review request on the tests.
Some thoughts on improvements:
- Why did you attach the tests as a diff instead of adding them to the review request? :-) ?
- Please add some more corner cases for the test (it's most likely that those fail): e.g.
* A Quad that covers the dateline/antimeridian
Any more ideas on what to test for? :-)</p></pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On Juni 29th, 2015, 9:01 vorm. UTC, Ana Badescu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Ana Badescu.</div>
<p style="color: grey;"><i>Updated Juni 29, 2015, 9:01 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Work in progress</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MergedLayerDecorator.cpp <span style="color: grey">(47ac63e)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLatLonQuad.h <span style="color: grey">(d38848a)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLatLonQuad.cpp <span style="color: grey">(6cb9748)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlLatLonQuadTagHandler.cpp <span style="color: grey">(57b3465)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124182/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/26/9e46bc90-031f-4f44-9723-d52ed15287e7__0001_Implement_latLonQuad_tag.diff">0001_Implement_latLonQuad_tag.diff</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/29/3f5a935c-555d-4204-9ea4-24c81b850fc8__0001_Implement_latLonQuad_tag.diff">0001_Implement_latLonQuad_tag.diff</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/29/8bed5582-7608-4508-9f96-70460b86e728__0002_Implement_latLonQuad_tag_test.diff">0002_Implement_latLonQuad_tag_test.diff</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>