<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110387/">https://git.reviewboard.kde.org/r/110387/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Juni 27, 2015, 11:08 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ScreenOverlays are fixed to the screen and are currently rendered by the GeometryLayer. According to the KML documentation, "Sample uses for ScreenOverlays are compasses, logos, and heads-up displays", so ScreenOverlays should (probably) be rendered in the "FLOAT_ITEMS" render position. Since GeometryLayer renders its objects in the "HOVERS_ABOVE_SURFACE" render position, the ScreenOverlay items should be moved into their own layer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleMap.cpp <span style="color: grey">(b3334e8ba9bfb7d9ef93dc2ee4ce561f1cc3f015)</span></li>
<li>src/lib/layers/CMakeLists.txt <span style="color: grey">(4efe657038de29f86dcfde6a3d7b4c10da35a8c9)</span></li>
<li>src/lib/layers/GeometryLayer.cpp <span style="color: grey">(92d44f3fb5c6e2e199d501157ca7bb8cab6db161)</span></li>
<li>src/lib/layers/ScreenLayer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/layers/ScreenLayer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110387/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>