<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124193/">https://git.reviewboard.kde.org/r/124193/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Juni 27th, 2015, 7:36 vorm. UTC, <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124193/diff/1/?file=381521#file381521line64" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">64</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">blendings/BlendingAlgorithms.cpp</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's not exactly great to maintain if we have to keep two cpp file lists. - I'd even claim it will break one week after GSoC is finished.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh I only just realized that Dennis had pointed out the same issue already.</p></pre>
<br />
<p>- Torsten</p>
<br />
<p>On Juni 27th, 2015, 7:22 vorm. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Juni 27, 2015, 7:22 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch includes some little bugfixes and some bulk class to compile without QtWebKit.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Previous review request:
https://git.reviewboard.kde.org/r/124064/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(78b83a39ac26b17b82b072d6309bb30d88bf6534)</span></li>
<li>src/apps/CMakeLists.txt <span style="color: grey">(2834e13025bf70a202163992e849a92e2801e1cf)</span></li>
<li>src/apps/marble_android/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble_android/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(8b36d0843f585c09c62bf044d0cfb0651a13d4b0)</span></li>
<li>src/lib/marble/HttpJob.cpp <span style="color: grey">(249b6800a4c0bfbc944020eb25019400bd4eff34)</span></li>
<li>src/lib/marble/LegendWidget.cpp <span style="color: grey">(b74373c92830856f29d3759f682dbf89c3dab6ae)</span></li>
<li>src/lib/marble/LegendWidgetQtNoWebkit.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.h <span style="color: grey">(7e80c389f9e8f0fe3876dc4fe23d917e70a078d9)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.cpp <span style="color: grey">(f628b835534063aa459d67ddff10f33466ac59cd)</span></li>
<li>src/lib/marble/MarbleModel.cpp <span style="color: grey">(04605c6f7261d03e720a3c071a63f459f982d909)</span></li>
<li>src/lib/marble/MarbleWebViewQtNoWebkit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleWebViewQtNoWebkit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/PopupItem.h <span style="color: grey">(4c65004d1386305c3394f5b343bc67cff9127f39)</span></li>
<li>src/lib/marble/PopupItem.cpp <span style="color: grey">(8dd885c6efa4ed1c0981f835339b031720a24d01)</span></li>
<li>src/lib/marble/TinyWebBrowserQtNoWebkit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/TinyWebBrowserQtNoWebkit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/WebPopupWidgetQtNoWebkit.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/cloudsync/RouteItemDelegate.cpp <span style="color: grey">(9670f1e3ccb643bab5400e84e01129b9cc6826a4)</span></li>
<li>src/lib/marble/routing/RoutingInputWidget.cpp <span style="color: grey">(40c4aad9a93d3255a66fbfb98487401ee597321e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124193/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>