<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124095/">https://git.reviewboard.kde.org/r/124095/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">seems fine (as long as temporary)</p></pre>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On Juni 14th, 2015, 8:26 nachm. UTC, Marius Stanciu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Marius Stanciu.</div>
<p style="color: grey;"><i>Updated Juni 14, 2015, 8:26 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The OsmObjectManager is a temporary solution for managing OSM id ( used to ref osm tags ). This will be changed as soon as I
find a feasible solution to store osm-specific data in placemarks.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The OsmObjectAttributeWriters is a convenience class used to write typical atributes ( more might be added later )</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The OsmTagTagWriter is a tool used to write tags like <tag k="key" v="value"></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No testing can be done, as these are just helper classes.
Compiles fine</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/runner/osm/OsmObjectManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/OsmObjectManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/handlers/OsmElementDictionary.h <span style="color: grey">(44a993c)</span></li>
<li>src/plugins/runner/osm/handlers/OsmElementDictionary.cpp <span style="color: grey">(f493e7b)</span></li>
<li>src/plugins/runner/osm/writers/OsmObjectAttributeWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/writers/OsmObjectAttributeWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/writers/OsmTagTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/writers/OsmTagTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124095/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>