<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123406/">https://git.reviewboard.kde.org/r/123406/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Marius Stanciu.</div>
<p style="color: grey;"><i>Updated April 29, 2015, 10:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed the mentioned issues( changed the default current item of the map view to MarbleWidget's current mapTheme Id ) and added some more comments</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Firstly:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">GeoDataMapChange is introduced, as a tour primitive. It adds the possibility to schedule a map theme or projection change from within the Tour Widget Playlist.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">MapChangeEditDialog makes editing possible for the GeoDataMapChange elements. It uses the same UI from the MapViewWidget.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KmlMapChangeTagWriter/Handler + KmlThemeTagHandler + KmlProjectionTagHandler make import/export possible this way:
Example kmlFile:
<mx:MapChange>
<mx:theme>earth/citylights/citylights.dgml</mx:theme>
<mx:projection>Spherical</mx:projection>
</mx:MapChange></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This, after parsing, represents a mapChange element that will change the current map theme to <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
earth/citylights/citylights.dgml and projection to Spherical (Globe)</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As it can be seen above, a new xml namespace was introduced (mx), because the new element is Marble only.</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Adds a new icon for the mapChange item. ( mapChange.png )</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Secondly:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A lot of code was refactored from MapViewWidget.cpp ( CelestialSortFilterProxyModel, MapViewItemDelegate classes )
to their own files, so they can be reused by the MapChangeEditDialog</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've tested the feature as much as I could and it worked. If you find any bugs, please report an issue.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/bitmaps/changeMap.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(f448f84)</span></li>
<li>src/lib/marble/CelestialSortFilterProxyModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/CelestialSortFilterProxyModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MapChangeEditDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MapChangeEditDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MapChangeTrack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MapChangeTrack.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MapViewItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MapViewItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MapViewWidget.cpp <span style="color: grey">(4d8f9f6)</span></li>
<li>src/lib/marble/TourItemDelegate.h <span style="color: grey">(d0d67d3)</span></li>
<li>src/lib/marble/TourItemDelegate.cpp <span style="color: grey">(b038a7f)</span></li>
<li>src/lib/marble/TourPlayback.cpp <span style="color: grey">(f9bf828)</span></li>
<li>src/lib/marble/TourWidget.h <span style="color: grey">(a6cb8ca)</span></li>
<li>src/lib/marble/TourWidget.cpp <span style="color: grey">(b9fab0e)</span></li>
<li>src/lib/marble/geodata/CMakeLists.txt <span style="color: grey">(fe22e24)</span></li>
<li>src/lib/marble/geodata/data/GeoDataMapChange.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/data/GeoDataMapChange.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h <span style="color: grey">(f2c062c)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp <span style="color: grey">(ea53d43)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlMapChangeTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlMapChangeTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlProjectionTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlProjectionTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlThemeTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlThemeTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/parser/GeoDataParser.cpp <span style="color: grey">(588b086)</span></li>
<li>src/lib/marble/geodata/parser/GeoDataTypes.h <span style="color: grey">(45d81d3)</span></li>
<li>src/lib/marble/geodata/parser/GeoDataTypes.cpp <span style="color: grey">(47fde69)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlMapChangeTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlMapChangeTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.h <span style="color: grey">(d01fd7b)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.cpp <span style="color: grey">(131e3ab)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlTagWriter.cpp <span style="color: grey">(47ca42c)</span></li>
<li>src/lib/marble/libmarble.qrc <span style="color: grey">(f30e887)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123406/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>