<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123259/">https://git.reviewboard.kde.org/r/123259/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 6th, 2015, 5:43 vorm. UTC, <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works nicely apart from the m_editStatusChangedNeeded oversight! :-) </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I guess the next task would be to fix the case where the lower boundary has a higher value than the upper one (and hence the groundoverlay is not rendered). I think this should be fixed by ensuring proper values inside the dragging functionality as well as the preset setting (if the globe is turned upside down - you can determine whether the globe is turned upside down by checking the value of the ViewportParams' polarity property).
In addition it might make sense to also allow rendering GroundOverlays of KML files where the bottom value is higher than the top one. But still in the first place we should create "proper" KML ourselves.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The suggested task should of course be a separate patch :)</p></pre>
<br />
<p>- Torsten</p>
<br />
<p>On April 5th, 2015, 9:17 nachm. UTC, Dávid Kolozsvári wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dávid Kolozsvári.</div>
<p style="color: grey;"><i>Updated April 5, 2015, 9:17 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Until now it wasn't possible to rotate the GroundOverlayFrame manually, only from it's properties menu, setting the angle in a spinbox.
This patch introduces a user-friendly manual rotation in edit mode, as well as new icons(thanks to Torsten Rahn) which are shown as handles around it's edges and corners.
Also, a bug was fixed in this patch: the GroundOverlayFrame wasn't able to capture the mouse events that occured outside of it's regions while a controlpoint(handle) was grabbed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Testing was done by me and it works fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/CMakeLists.txt <span style="color: grey">(7b96438)</span></li>
<li>data/bitmaps/editarrows/arrow-diagonal-topleft-active.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-diagonal-topleft.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-diagonal-topright-active.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-diagonal-topright.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-horizontal-active.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-horizontal.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-rotation-bottomleft-active.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-rotation-bottomleft.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-rotation-bottomright-active.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-rotation-bottomright.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-rotation-topleft-active.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-rotation-topleft.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-rotation-topright-active.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-rotation-topright.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-vertical-active.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/editarrows/arrow-vertical.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.cpp <span style="color: grey">(45e8746)</span></li>
<li>src/plugins/render/annotate/GroundOverlayFrame.h <span style="color: grey">(194ade5)</span></li>
<li>src/plugins/render/annotate/GroundOverlayFrame.cpp <span style="color: grey">(c27eabd)</span></li>
<li>src/plugins/render/annotate/SceneGraphicsItem.h <span style="color: grey">(c59340e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123259/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>