<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122731/">https://git.reviewboard.kde.org/r/122731/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated April 3, 2015, 9:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit ac91cf9f27c355754fd7e8c6df9256a753cb8545 by Dennis Nienhüser on behalf of Rex Dieter to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Support qt4/qt5 parallel-installabie libmarblewidget. Current mplementation preserves compatibility with qt4 builds, and qt5 builds changes base library soname to be libmarblewidget-qt5 instead.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Marble and subsurface (a qt5 app that uses libmarblewidget) builds and runs... mostly (there seems to be some problem with loading marble plugins though)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ace9a51)</span></li>
<li>FindMarble.cmake <span style="color: grey">(99f017a)</span></li>
<li>FindMarble.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>MarbleMacros.cmake <span style="color: grey">(b86481f)</span></li>
<li>src/apps/marble-kde/CMakeLists.txt <span style="color: grey">(384f867)</span></li>
<li>src/apps/marble-mobile/CMakeLists.txt <span style="color: grey">(b86cac1)</span></li>
<li>src/apps/marble-qt/CMakeLists.txt <span style="color: grey">(75b465e)</span></li>
<li>src/apps/marble-touch/CMakeLists.txt <span style="color: grey">(1d37cd4)</span></li>
<li>src/apps/marble-ui/CMakeLists.txt <span style="color: grey">(74f1849)</span></li>
<li>src/bindings/python/CMakeLists.txt <span style="color: grey">(57683cb)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(6c65015)</span></li>
<li>src/plasmarunner/CMakeLists.txt <span style="color: grey">(b52cc35)</span></li>
<li>src/plasmoid/CMakeLists.txt <span style="color: grey">(03e251c)</span></li>
<li>src/plugins/designer/latloneditwidget/CMakeLists.txt <span style="color: grey">(eb5d543)</span></li>
<li>src/plugins/runner/gpx/CMakeLists.txt <span style="color: grey">(aed6f83)</span></li>
<li>src/thumbnailer/CMakeLists.txt <span style="color: grey">(175b5fc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122731/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>