<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123122/">https://git.reviewboard.kde.org/r/123122/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble, Calin Cruceru and Torsten Rahn.</div>
<div>By Constantin Mihalache.</div>
<p style="color: grey;"><i>Updated April 1, 2015, 11:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add explicit keyword to FormattedTextWidget constructor. change getText() to text().</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 Widget implementation:</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've respected the structured given by EditPlacemarkDialog, which had formatted description.
I've first added this functionality to Polygon, Polyline and GroundOverlay editing.
I've also replaced the code in EditPlacemarkDialog with the widget.</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 Solved a visual bug in EditPolygonDialog and EditPolylineDialog:</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The node table header didn't stretch with the window.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It works.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(6c65015)</span></li>
<li>src/lib/marble/EditPlacemarkDialog.h <span style="color: grey">(015173c)</span></li>
<li>src/lib/marble/EditPlacemarkDialog.cpp <span style="color: grey">(3d0d61f)</span></li>
<li>src/lib/marble/EditPlacemarkDialog.ui <span style="color: grey">(e17bf14)</span></li>
<li>src/lib/marble/FormattedTextWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/FormattedTextWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/FormattedTextWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/EditGroundOverlayDialog.cpp <span style="color: grey">(df7d6d2)</span></li>
<li>src/plugins/render/annotate/EditGroundOverlayDialog.ui <span style="color: grey">(1151b35)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.cpp <span style="color: grey">(c647e6b)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.ui <span style="color: grey">(563ca2d)</span></li>
<li>src/plugins/render/annotate/EditPolylineDialog.cpp <span style="color: grey">(a99a3e9)</span></li>
<li>src/plugins/render/annotate/EditPolylineDialog.ui <span style="color: grey">(3421a72)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123122/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>