<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122938/">https://git.reviewboard.kde.org/r/122938/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 20th, 2015, 11 a.m. UTC, <b>Calin Cruceru</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good. Wait for Torsten's approval as well. :)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i'll start working on the Polylines version of this when this gets shipped, since i could reuse the nodeitem delegate from this patch.</p></pre>
<br />
<p>- Marius</p>
<br />
<p>On March 20th, 2015, 10:42 a.m. UTC, Marius Stanciu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Marius Stanciu.</div>
<p style="color: grey;"><i>Updated March 20, 2015, 10:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In order to do this, i used the already availible widget LatLonEdit and set it as the model's edit wdiget, via a new delegate class.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This allows real-time modification of the nodes with the LatLonEdit's high precision. ( Even though dragging the nodes was possible, it wasn't really precise, and it did not allow exact coordinates input ( keyboard input ).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works for me.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/EditPlacemarkDialog.h <span style="color: grey">(24a5610)</span></li>
<li>src/plugins/render/annotate/CMakeLists.txt <span style="color: grey">(594ea89)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.h <span style="color: grey">(6f07648)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.cpp <span style="color: grey">(8c8b302)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.ui <span style="color: grey">(0bfa86e)</span></li>
<li>src/plugins/render/annotate/NodeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/NodeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/NodeModel.h <span style="color: grey">(4586eea)</span></li>
<li>src/plugins/render/annotate/NodeModel.cpp <span style="color: grey">(984a2be)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122938/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>