<html><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px"><div id="yui_3_16_0_1_1425538646881_14709">Being on qt5 already I very much favor this option : Qt4: libmarblewidget-qt4
- Qt5: libmarblewidget</div><div id="yui_3_16_0_1_1425538646881_15213"><br></div><div id="yui_3_16_0_1_1425538646881_15214">;)</div><div id="yui_3_16_0_1_1425538646881_15578"><br></div><div id="yui_3_16_0_1_1425538646881_15579" dir="ltr">Philippe.<br></div><div id="yui_3_16_0_1_1425538646881_14708"><span></span></div> <div class="qtdSeparateBR"><br><br></div><div style="display: block;" class="yahoo_quoted"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div dir="ltr"> <font size="2" face="Arial"> Le Dimanche 1 mars 2015 20h01, Dennis Nienhüser <earthwings@gentoo.org> a écrit :<br> </font> </div> <blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; margin-top: 5px; padding-left: 5px;"> <br><br> <div class="y_msg_container"><div id="yiv1301346901"><div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif;">
<table style="border:1px #c9c399 solid;" bgcolor="#f9f3c9" width="100%" cellpadding="12"><tbody><tr><td colspan="1" rowspan="1">
This is an automatically generated e-mail. To reply, visit:
<a rel="nofollow" shape="rect" target="_blank" href="https://git.reviewboard.kde.org/r/122731/">https://git.reviewboard.kde.org/r/122731/</a>
</td></tr></tbody></table>
<br clear="none">
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px;">
<div style="margin-top:0;">On February 28th, 2015, 4:06 p.m. UTC, <b>Dennis Nienhüser</b> wrote:</div>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px;">
<pre style="white-space:pre-wrap;word-wrap:break-word;"></pre><div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">Makes sense generally. I do not have a system to test with at the moment, but the problems with plugin loading sound like a must-fix before shipping. Got some details on it? Do some plugins load, or none? Is it related to the qt version?</div>
</blockquote>
<div>On February 28th, 2015, 4:55 p.m. UTC, <b>Rex Dieter</b> wrote:</div>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px;">
<pre style="white-space:pre-wrap;word-wrap:break-word;"></pre><div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">Looks like I'm getting the same crashes without this patch, so probably unrelated. I'll file a bug (separately).</div>
</blockquote>
<div>On March 1st, 2015, 6:25 a.m. UTC, <b>Rex Dieter</b> wrote:</div>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px;">
<pre style="white-space:pre-wrap;word-wrap:break-word;"></pre><div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">bug filed, https://bugs.kde.org/show_bug.cgi?id=344692</div>
</blockquote>
</blockquote>
<pre style="white-space:pre-wrap;word-wrap:break-word;"></pre><div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">With this patch we get
- Qt4: libmarblewidget
- Qt5: libmarblewidget-qt5</div>
<div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">Other options would be
- Qt4: libmarblewidget-qt4
- Qt5: libmarblewidget</div>
<div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">and also
- Qt4: libmarblewidget-qt4
- Qt5: libmarblewidget-qt5</div>
<div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">and last but not least using different folders for each installation.</div>
<div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">I'm mereley thinking aloud to avoid that we forget a viable option. The current patch might confuse some people / build scripts when changing from qt4 to qt5 and the (possibly hardcoded) libmarblewidget does not exist anymore. Using libmarblewidget-qt4/libmarblewidget would stress that qt5 is the new default which I'd like to push; using libmarblewidget-qt4/libmarblewidget-qt5 seems more consistent.</div>
<div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">Opinions, anyone?</div>
<br clear="none">
<div>- Dennis</div>
<br clear="none">
<div>On February 26th, 2015, 6:50 p.m. UTC, Rex Dieter wrote:</div>
<table style="border:1px #888a85 solid;" bgcolor="#fefadf" width="100%" cellpadding="12" cellspacing="0"><tbody><tr><td colspan="1" rowspan="1">
<div>Review request for Marble.</div>
<div>By Rex Dieter.</div>
<div style="color:grey;"><i>Updated Feb. 26, 2015, 6:50 p.m.</i></div>
<div class="yiv1301346901yqt2197999095" id="yiv1301346901yqtfd10945"><div style="margin-top:1.5em;">
<b style="color:#575012;font-size:10pt;">Repository: </b>
marble
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em;">Description </h1>
<table style="border:1px solid #b8b5a0;" bgcolor="#ffffff" width="100%" cellpadding="10" cellspacing="0"><tbody><tr><td colspan="1" rowspan="1">
<pre style="margin:0;padding:0;white-space:pre-wrap;word-wrap:break-word;"></pre><div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">Support qt4/qt5 parallel-installabie libmarblewidget. Current mplementation preserves compatibility with qt4 builds, and qt5 builds changes base library soname to be libmarblewidget-qt5 instead.</div>
</td></tr></tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em;">Testing </h1>
<table style="border:1px solid #b8b5a0;" bgcolor="#ffffff" width="100%" cellpadding="10" cellspacing="0"><tbody><tr><td colspan="1" rowspan="1">
<pre style="margin:0;padding:0;white-space:pre-wrap;word-wrap:break-word;"></pre><div style="padding:0;margin:0;line-height:inherit;white-space:inherit;">Marble and subsurface (a qt5 app that uses libmarblewidget) builds and runs... mostly (there seems to be some problem with loading marble plugins though)</div>
</td></tr></tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em;">Diffs </h1>
<ul style="margin-left:3em;padding-left:0;"><li>CMakeLists.txt <span style="color:grey;">(ace9a51)</span></li><li>FindMarble.cmake <span style="color:grey;">(99f017a)</span></li><li>FindMarble.cmake.in <span style="color:grey;">(PRE-CREATION)</span></li><li>MarbleMacros.cmake <span style="color:grey;">(b86481f)</span></li><li>src/apps/marble-kde/CMakeLists.txt <span style="color:grey;">(384f867)</span></li><li>src/apps/marble-mobile/CMakeLists.txt <span style="color:grey;">(b86cac1)</span></li><li>src/apps/marble-qt/CMakeLists.txt <span style="color:grey;">(75b465e)</span></li><li>src/apps/marble-touch/CMakeLists.txt <span style="color:grey;">(1d37cd4)</span></li><li>src/apps/marble-ui/CMakeLists.txt <span style="color:grey;">(74f1849)</span></li><li>src/bindings/python/CMakeLists.txt <span style="color:grey;">(57683cb)</span></li><li>src/lib/marble/CMakeLists.txt <span style="color:grey;">(6c65015)</span></li><li>src/plasmarunner/CMakeLists.txt <span style="color:grey;">(b52cc35)</span></li><li>src/plasmoid/CMakeLists.txt <span style="color:grey;">(03e251c)</span></li><li>src/plugins/designer/latloneditwidget/CMakeLists.txt <span style="color:grey;">(eb5d543)</span></li><li>src/plugins/runner/gpx/CMakeLists.txt <span style="color:grey;">(aed6f83)</span></li><li>src/thumbnailer/CMakeLists.txt <span style="color:grey;">(175b5fc)</span></li></ul>
<div><a rel="nofollow" shape="rect" target="_blank" href="https://git.reviewboard.kde.org/r/122731/diff/" style="margin-left:3em;">View Diff</a></div>
</div></td></tr></tbody></table><div class="yiv1301346901yqt2197999095" id="yiv1301346901yqtfd72456">
</div></div><div class="yiv1301346901yqt2197999095" id="yiv1301346901yqtfd55060">
</div></div></div><br><div class="yqt2197999095" id="yqtfd14180">_______________________________________________<br clear="none">Marble-devel mailing list<br clear="none"><a shape="rect" ymailto="mailto:Marble-devel@kde.org" href="mailto:Marble-devel@kde.org">Marble-devel@kde.org</a><br clear="none"><a shape="rect" href="https://mail.kde.org/mailman/listinfo/marble-devel" target="_blank">https://mail.kde.org/mailman/listinfo/marble-devel</a><br clear="none"></div><br><br></div> </blockquote> </div> </div> </div> </div></body></html>