<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122731/">https://git.reviewboard.kde.org/r/122731/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 28th, 2015, 4:06 p.m. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes sense generally. I do not have a system to test with at the moment, but the problems with plugin loading sound like a must-fix before shipping. Got some details on it? Do some plugins load, or none? Is it related to the qt version?</p></pre>
</blockquote>
<p>On February 28th, 2015, 4:55 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks like I'm getting the same crashes without this patch, so probably unrelated. I'll file a bug (separately).</p></pre>
</blockquote>
<p>On March 1st, 2015, 6:25 a.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">bug filed, https://bugs.kde.org/show_bug.cgi?id=344692</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With this patch we get
- Qt4: libmarblewidget
- Qt5: libmarblewidget-qt5</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other options would be
- Qt4: libmarblewidget-qt4
- Qt5: libmarblewidget</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and also
- Qt4: libmarblewidget-qt4
- Qt5: libmarblewidget-qt5</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and last but not least using different folders for each installation.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm mereley thinking aloud to avoid that we forget a viable option. The current patch might confuse some people / build scripts when changing from qt4 to qt5 and the (possibly hardcoded) libmarblewidget does not exist anymore. Using libmarblewidget-qt4/libmarblewidget would stress that qt5 is the new default which I'd like to push; using libmarblewidget-qt4/libmarblewidget-qt5 seems more consistent.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Opinions, anyone?</p></pre>
<br />
<p>- Dennis</p>
<br />
<p>On February 26th, 2015, 6:50 p.m. UTC, Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2015, 6:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Support qt4/qt5 parallel-installabie libmarblewidget. Current mplementation preserves compatibility with qt4 builds, and qt5 builds changes base library soname to be libmarblewidget-qt5 instead.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Marble and subsurface (a qt5 app that uses libmarblewidget) builds and runs... mostly (there seems to be some problem with loading marble plugins though)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ace9a51)</span></li>
<li>FindMarble.cmake <span style="color: grey">(99f017a)</span></li>
<li>FindMarble.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>MarbleMacros.cmake <span style="color: grey">(b86481f)</span></li>
<li>src/apps/marble-kde/CMakeLists.txt <span style="color: grey">(384f867)</span></li>
<li>src/apps/marble-mobile/CMakeLists.txt <span style="color: grey">(b86cac1)</span></li>
<li>src/apps/marble-qt/CMakeLists.txt <span style="color: grey">(75b465e)</span></li>
<li>src/apps/marble-touch/CMakeLists.txt <span style="color: grey">(1d37cd4)</span></li>
<li>src/apps/marble-ui/CMakeLists.txt <span style="color: grey">(74f1849)</span></li>
<li>src/bindings/python/CMakeLists.txt <span style="color: grey">(57683cb)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(6c65015)</span></li>
<li>src/plasmarunner/CMakeLists.txt <span style="color: grey">(b52cc35)</span></li>
<li>src/plasmoid/CMakeLists.txt <span style="color: grey">(03e251c)</span></li>
<li>src/plugins/designer/latloneditwidget/CMakeLists.txt <span style="color: grey">(eb5d543)</span></li>
<li>src/plugins/runner/gpx/CMakeLists.txt <span style="color: grey">(aed6f83)</span></li>
<li>src/thumbnailer/CMakeLists.txt <span style="color: grey">(175b5fc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122731/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>