<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122004/">https://git.reviewboard.kde.org/r/122004/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch renames <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">EditTextAnnotationDialog</code> to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">EditPlacemarkDialog</code> and introduces a fix to a bug:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Create a Placemark via "Add Placemark"</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">In the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">EditTextAnnotationDialog</code> keep the label color as black.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Once you closed the dialog the placemark label appears blue. This is correct due to the selected state.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">However once you click the placemark icon with the left mouse button and then invoke the RMB menu via the right mouse button and click "Properties" the text label color incorrectly appears as "blue" in the dialog (while it should be shown as black).</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Related GCI-2014 task: https://www.google-melange.com/gci/task/view/google/gci2014/5909169097932800</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Double-testing, everything works as expected, colors get changed normally.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/EditTextAnnotationDialog.cpp <span style="color: grey">(1472a6f)</span></li>
<li>src/lib/marble/EditTextAnnotationDialog.ui <span style="color: grey">(fe64dc2)</span></li>
<li>src/lib/marble/FileViewWidget.cpp <span style="color: grey">(f26b21b)</span></li>
<li>src/lib/marble/TourItemDelegate.cpp <span style="color: grey">(326b7ea)</span></li>
<li>src/lib/marble/TourWidget.cpp <span style="color: grey">(b0b45da)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.cpp <span style="color: grey">(8b2e596)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(bb102df)</span></li>
<li>src/lib/marble/EditPlacemarkDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/EditPlacemarkDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/EditPlacemarkDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/EditTextAnnotationDialog.h <span style="color: grey">(db2ad94)</span></li>
<li>src/plugins/render/annotate/PlacemarkTextAnnotation.h <span style="color: grey">(008c666)</span></li>
<li>src/plugins/render/annotate/PlacemarkTextAnnotation.cpp <span style="color: grey">(d7f879d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122004/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>