<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121940/">https://git.reviewboard.kde.org/r/121940/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks cool, some issues:</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121940/diff/1/?file=339208#file339208line468" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/PlacemarkEditHeader.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">468</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">m_iconLink</span><span class="o">-></span><span class="n">setReadOnly</span><span class="p">(</span><span class="n">state</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe you mean iconLinkButton?</p></pre>
</div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When I open dialog for placemark without some fields (from cityplacemarks GeoDataDocument for example) EditTextAnnotation::checkFields is called and <img alt="dialog" src="http://ematirov.tk/dialog.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> appear.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, maybe we shouldn't set "id" while opening in read-only mode? (For example, "Vidisha" from cityplacemarks has no ID and it's set to "vidisha" after opening).</p></pre>
<p>- Mihail Ivchenko</p>
<br />
<p>On January 10th, 2015, 4:03 p.m. SAMT, Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble, Bernhard Beschow, Mihail Ivchenko, Dennis Nienhüser, and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2015, 4:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds "View Properties" feature to newly introduced right mouse click menu on placemarks from <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">FileView</code> panel, by reusing <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">EditTextAnnotationDialog</code>. This also introduces read-only mode for <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">EditTextAnnotationDialog</code>, so placemark data won't get changed anyway.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5849514216783872</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Right</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/EditTextAnnotationDialog.cpp <span style="color: grey">(2caa13a)</span></li>
<li>src/lib/marble/FileViewWidget.h <span style="color: grey">(bd44e6d)</span></li>
<li>src/lib/marble/EditTextAnnotationDialog.h <span style="color: grey">(4d812f1)</span></li>
<li>src/lib/marble/FileViewWidget.cpp <span style="color: grey">(e0de340)</span></li>
<li>src/lib/marble/PlacemarkEditHeader.h <span style="color: grey">(77c8259)</span></li>
<li>src/lib/marble/PlacemarkEditHeader.cpp <span style="color: grey">(9ca61b3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121940/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/99981361-1188-4aa7-a874-47d6c4c72757__Screen_Shot_2015-01-09_at_8.36.13_PM.png">Context menu</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/0d44034e-f796-46e3-b2b4-0d63570ea3c8__Screen_Shot_2015-01-09_at_8.36.26_PM.png">Placemark View</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>