<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121875/">https://git.reviewboard.kde.org/r/121875/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Januar 6th, 2015, 11:02 nachm. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121875/diff/2/?file=338569#file338569line54" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/MarbleLocale.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qreal</span> <span class="o">*</span><span class="n">targetValue</span><span class="p">,</span> <span class="n">MeasureUnit</span> <span class="o">*</span><span class="n">targetUnit</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please pass those by reference. You seem to depend on the existance of those variables anyway.</p></pre>
</blockquote>
<p>On Januar 7th, 2015, 12:16 nachm. UTC, <b>Illya Kovalevskyy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(13:33:56) tackat: I don't agree on the reference part
(13:37:30) tackat: it's easier to see in the written code that these parameters are supposed to be modified</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I disagree on this one. In this case it's better and imho more Qt style to pass the parameters as pointers since this sets these parameters clearly apart as "writable" compared to the others. See e.g. http://qt-project.org/doc/qt-4.8/qcolor.html#getRgb</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Januar 6th, 2015, 11:02 nachm. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121875/diff/2/?file=338571#file338571line77" style="color: black; font-weight: bold; text-decoration: underline;">tests/LocaleTest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">77</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QVERIFY</span><span class="p">(</span><span class="n">qAbs</span><span class="p">(</span><span class="n">targetValue</span><span class="o">-</span><span class="n">value</span><span class="p">)</span> <span class="o"><</span> <span class="mf">0.033</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Did you try using QCOMPARE here? According to the documentation [1], qFuzzyCompare() is used for floats and doubles (i.e. qreals), so QCOMPARE should work.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] http://qt-project.org/doc/qt-4.8/qtest.html#QCOMPARE</p></pre>
</blockquote>
<p>On Januar 7th, 2015, 11:40 vorm. UTC, <b>Illya Kovalevskyy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">qFuzzyCompare works for 10^-8 or smth, but precision of our conversation constants is much much lower. It's around 10^-4 or 10^-4, so I'd like to compare these up to 0.3(3).</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is a QFUZZYCOMPARE macro which allows to specify the precision as a second parameter. Check the tests for the projection classes to see it in action.</p></pre>
<br />
<p>- Torsten</p>
<br />
<p>On Januar 7th, 2015, 1:52 nachm. UTC, Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2015, 1:52 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch expands MarbleLocale API, so it covers measurement units and also does add elevation widget to annotation plugin.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Related GCI task: http://www.google-melange.com/gci/task/view/google/gci2014/5879562479075328</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Positive</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/photo/PhotoPluginModel.cpp <span style="color: grey">(8b85af5)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(36ef40b)</span></li>
<li>tests/LocaleTest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/TourWidget.cpp <span style="color: grey">(c837f1d)</span></li>
<li>src/plugins/render/panoramio/PanoramioModel.cpp <span style="color: grey">(439b6b3)</span></li>
<li>src/lib/marble/TourWidget.h <span style="color: grey">(22a3325)</span></li>
<li>src/lib/marble/TourItemDelegate.h <span style="color: grey">(25485a9)</span></li>
<li>src/lib/marble/TourItemDelegate.cpp <span style="color: grey">(c4c5b24)</span></li>
<li>CMakeLists.txt <span style="color: grey">(ace9a51)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(807df82)</span></li>
<li>src/lib/marble/EditTextAnnotationDialog.h <span style="color: grey">(4d812f1)</span></li>
<li>src/lib/marble/EditTextAnnotationDialog.cpp <span style="color: grey">(f3dd80b)</span></li>
<li>src/lib/marble/ElevationWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleGlobal.h <span style="color: grey">(bd7d63f)</span></li>
<li>src/lib/marble/MarbleLocale.h <span style="color: grey">(0b5414b)</span></li>
<li>src/lib/marble/MarbleLocale.cpp <span style="color: grey">(653f69b)</span></li>
<li>src/lib/marble/PlacemarkEditHeader.h <span style="color: grey">(77c8259)</span></li>
<li>src/lib/marble/PlacemarkEditHeader.cpp <span style="color: grey">(9ca61b3)</span></li>
<li>src/lib/marble/PlacemarkEditHeader.ui <span style="color: grey">(606a709)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121875/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>