<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121769/">https://git.reviewboard.kde.org/r/121769/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On Dezember 30th, 2014, 8:30 nachm. UTC, Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Dez. 30, 2014, 8:30 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch gets rid of EARTH_RADIUS where it's possible, replacing it with Planet class approach and fixes using "R" variable in codebase.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5308478797119488</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unit tests, visual testing</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-ui/ControlView.cpp <span style="color: grey">(64c6b85)</span></li>
<li>src/lib/marble/PositionTracking.h <span style="color: grey">(0e7f951)</span></li>
<li>src/lib/marble/routing/RoutingModel.cpp <span style="color: grey">(a90f248)</span></li>
<li>src/lib/marble/routing/RoutingWidget.cpp <span style="color: grey">(b0171aa)</span></li>
<li>src/plugins/declarative/Bookmarks.cpp <span style="color: grey">(4fa2316)</span></li>
<li>src/plugins/declarative/Navigation.cpp <span style="color: grey">(575179b)</span></li>
<li>src/plugins/render/measure/MeasureToolPlugin.cpp <span style="color: grey">(b292c23)</span></li>
<li>src/plugins/render/positionmarker/PositionMarker.h <span style="color: grey">(cf24599)</span></li>
<li>src/plugins/render/positionmarker/PositionMarker.cpp <span style="color: grey">(45f20c5)</span></li>
<li>src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(09aec31)</span></li>
<li>src/plugins/render/satellites/SatellitesTLEItem.cpp <span style="color: grey">(57adefe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121769/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>