<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121540/">https://git.reviewboard.kde.org/r/121540/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While I like the idea of moving the annotation plugin actions into a panel, I think QDockWidget creation does not belong in RenderPlugin. Our RenderPlugins are very much tied to Desktop-Marble already (see the attempt of integrating them into Marble Touch), so adding another QWidget dependency makes the situation even worse.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In addition, I believe that the Annotation Plugin should only be a temporary appearance since it has various design issues. It really doesn't make sense for the plugin to implement its own way of rendering geometries rather than using GeoDataTreeModel. This doesn't only create several inconsistencies but also complicates porting to OpenGL. Moreover, why doesn't Marble allow editing of any user-loaded document right in FileViewWidget? So if the plugin's code was merged into the core we didn't need to pollute the RenderPlugin API even further.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Perhaps we can come up with GCI tasks for merging the Annotation Plugin into the core step by step. This needs brainstorming and detailed planning, however.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How shall we proceed here?</p></pre>
<br />
<p>- Bernhard Beschow</p>
<br />
<p>On Dezember 15th, 2014, 9:43 nachm. UTC, Mihail Ivchenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Mihail Ivchenko.</div>
<p style="color: grey;"><i>Updated Dez. 15, 2014, 9:43 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Move annotation plugin actions into an "Edit Maps" panel
Also, now it's possible to add QDockWidgets to window from plugins.
GCI task: http://www.google-melange.com/gci/task/view/google/gci2014/5809396621770752</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-ui/ControlView.h <span style="color: grey">(5cb75a5)</span></li>
<li>src/apps/marble-ui/ControlView.cpp <span style="color: grey">(04657fc)</span></li>
<li>src/lib/marble/RenderPlugin.h <span style="color: grey">(67472fa)</span></li>
<li>src/lib/marble/RenderPlugin.cpp <span style="color: grey">(1f2e9b1)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.h <span style="color: grey">(96e966f)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.cpp <span style="color: grey">(263448c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121540/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/233847c3-cd95-44bd-8df5-def5d74ba243__annotate.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>