<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120030/">https://git.reviewboard.kde.org/r/120030/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Dezember 3rd, 2014, 9:09 nachm. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In essence, I am still looking for the reason why stacked widgets aren't considered simple enough.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bernhard: Neither of the available solutions is beautiful. Currently using the Marble widget gets us up to 200 MB RSS RAM (should be optimized again - it was 100 MB in the past and IIRC the high amount is due to the fact that we don't drop the source tile layers from memory after we merge them into the resultTiles). Creating two widgets brings that up to 400 MB - unless we unload the content from the "invisible" marble widget instance.
You are correct that we shouldn't let these patches rot. I'm not religious about any of the proposed solutions. So we should discuss them and pick one.</p></pre>
<br />
<p>- Torsten</p>
<br />
<p>On September 4th, 2014, 3 nachm. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2014, 3 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds the ability to save sessions at runtime and start a new one and later return to the previous one.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-This could be improved with adding the ability to change between sessions without closing any.
-Also it could be improved/used up to create an undo ability (Maybe with QUndo?)
-It could be used up to support high resolution printing with creating a session in the background</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/SessionManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/SessionManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(482a241a4e61fc26cede3b9140cbd320016d0ac2)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.h <span style="color: grey">(9518e7e77797d026d78d4740a8c813c943868883)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.cpp <span style="color: grey">(ecb29cb90826c421ef90f423466f344bdbb498ac)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(75d2d8f63021e5c278f5e57e30f03f093b068943)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120030/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>