<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118203/">https://git.reviewboard.kde.org/r/118203/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118203/diff/5/?file=276044#file276044line1159" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/MarbleWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MarbleWidget::setVolatileTileCacheLimit( quint64 kiloBytes )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1153</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">993</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">{</span> <span class="c1">//</span><span class="cs">TODO</span><span class="c1"> - move to MarbleAbstractPresenter as soon as RoutingLayer is ported there, replace with pImpl call</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This TODO hasn't been resolved in Applications/14.12, the upcoming stable branch. Since this method isn't called any more, the RoutingLayer isn't informed about the view context, resulting in very poor route rendering performance. How shall we fix this?</p></pre>
</div>
</div>
<br />
<p>- Bernhard Beschow</p>
<br />
<p>On Mai 29th, 2014, 9:33 vorm. UTC, Adam Dabrowski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Adam Dabrowski.</div>
<p style="color: grey;"><i>Updated Mai 29, 2014, 9:33 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A first step to port Marble to Qt Quick 2.0
Extracted most of QWidget-independent implementation code from MarbleWidget into MarbleAbstractPresenter
Adjusted MarblePhysics as an example of a port for a class that formerly used MarbleWidget
Wrote a stub QQuickItem class. This was tested with QML 2.0 and works (displays maps and reacts to keyboard input).
Still a work in progress, but a chunk that can be pushed without breaking anything.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using attached app.
Also did a regression tests for MarbleWidget (simple ones)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>examples/cpp/CMakeLists.txt <span style="color: grey">(98a1ae4)</span></li>
<li>examples/cpp/marbleQuick2/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>examples/cpp/marbleQuick2/CMakeLists.txt.external <span style="color: grey">(PRE-CREATION)</span></li>
<li>examples/cpp/marbleQuick2/Readme.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>examples/cpp/marbleQuick2/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>examples/cpp/marbleQuick2/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(5b4a0ee)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarblePhysics.h <span style="color: grey">(8559809)</span></li>
<li>src/lib/marble/MarblePhysics.cpp <span style="color: grey">(9c4b112)</span></li>
<li>src/lib/marble/MarbleQuickItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleQuickItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(10b466e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118203/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>