<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109379/">https://git.reviewboard.kde.org/r/109379/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Bernhard Beschow.</div>
<div>By Roman Karlstetter.</div>
<p style="color: grey;"><i>Updated Oct. 11, 2014, 4:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes to the elevation profile plugin, it's now possible to display the height profile for a GPX-track opened from file.
I made a new classes for
a) providing the data, one for routes and one for tracks. They are in the same file, should this be split into multiple files?
b) the contextmenu, because it has some members which would only clutter ElevationProfileFloatItem. It is a friend class, is this ok?
Comments please :) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/elevationprofilefloatitem/CMakeLists.txt <span style="color: grey">(872e5e1)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.h <span style="color: grey">(cb3bff1)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp <span style="color: grey">(0cbf307)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileRouteDataSource.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileRouteDataSource.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileTrackDataSource.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileTrackDataSource.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109379/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>