<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119903/">https://git.reviewboard.kde.org/r/119903/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why does this contain the GnomonicScanlineTexturmapper (which would rather belong to the projection patch ? :)</p></pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On August 23rd, 2014, 9:09 nachm. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2014, 9:09 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch contains the code for creating map theme from GeoDataPhotoOverlay, visualising with a MarbleWidget and managing temporary files for the proccess.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleMap.cpp <span style="color: grey">(25007ac7921df3ca447eb587e9d12ffc838e6856)</span></li>
<li>src/lib/marble/MarbleModel.h <span style="color: grey">(9643186b62429a4e04f421030d64b8ab86cd7f7c)</span></li>
<li>src/lib/marble/MarbleModel.cpp <span style="color: grey">(3bd408c76f29ef8e39430b9d8e1645cf0b17f95f)</span></li>
<li>src/lib/marble/MarbleWidget.h <span style="color: grey">(dfc1aa7bc8004e96a7759d06165580bf8c56b63c)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(d4c7ff48145bd55de23cf0a0e4a2b92e8037bb29)</span></li>
<li>src/lib/marble/MarbleWidgetPopupMenu.cpp <span style="color: grey">(1dc7760903f4899e830d754957651c6681172971)</span></li>
<li>src/lib/marble/PopupItem.h <span style="color: grey">(4c65004d1386305c3394f5b343bc67cff9127f39)</span></li>
<li>src/lib/marble/PopupItem.cpp <span style="color: grey">(a4e973ad60a2a8dd24fc5370b6eaf95b247f5bb5)</span></li>
<li>src/lib/marble/RenderPlugin.h <span style="color: grey">(67472fa005f191c823f188848926f87150ba9c98)</span></li>
<li>src/lib/marble/RenderPlugin.cpp <span style="color: grey">(1f2e9b1f679914a96337042fd6d9b347dac2533e)</span></li>
<li>src/lib/marble/ViewportParams.cpp <span style="color: grey">(d6cf03603b353671f52440adcea15ddecf188b94)</span></li>
<li>src/lib/marble/WebPopupWidget.ui <span style="color: grey">(8cf7103185281833924b0e36da655b2fbe19b8b6)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPhotoOverlay.cpp <span style="color: grey">(456886b28df1df424dcc5c8577ccad6b38174bd0)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPlacemark.h <span style="color: grey">(96028e426a9688ffbb48cf8942eba2455a06b581)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPlacemark.cpp <span style="color: grey">(b2d0304ec10e2243538cf1cdb252c2da7f0cde5c)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPlacemark_p.h <span style="color: grey">(b4c1ee1a7f53d596baada68c94bba72cb26a9e53)</span></li>
<li>src/lib/marble/geodata/graphicsitem/GeoPhotoGraphicsItem.cpp <span style="color: grey">(4fab8fb25528706527e9138d10a4850c20025437)</span></li>
<li>src/lib/marble/layers/GeometryLayer.h <span style="color: grey">(8d86aed059f7d6e36fd668bedb1f26d467cd2887)</span></li>
<li>src/lib/marble/MapViewWidget.cpp <span style="color: grey">(b55dc1cfbf5caa7d44846bedaf048648009a6076)</span></li>
<li>src/lib/marble/MarbleGlobal.h <span style="color: grey">(69a96f3badc69edc36a0163a173f7214fe71aeb5)</span></li>
<li>src/lib/marble/MapViewWidget.h <span style="color: grey">(9a86c1e5d06df2a1ed44eab8f10544cf3b8acc7e)</span></li>
<li>src/lib/marble/MapThemeManager.h <span style="color: grey">(d18c8de6ec29153e00d079a4b30579ca1d9be14d)</span></li>
<li>src/lib/marble/MapThemeManager.cpp <span style="color: grey">(725cc44614073b2ee114a448ce08254ceffa4f5d)</span></li>
<li>src/lib/marble/LayerManager.h <span style="color: grey">(858fcdaf93810ce3f3b159aacc463c79725b06e6)</span></li>
<li>src/lib/marble/LayerManager.cpp <span style="color: grey">(436473162b5d473038f33a1eb75afb5844f86a91)</span></li>
<li>src/lib/marble/GnomonicScanlineTextureMapper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/FileStoragePolicy.cpp <span style="color: grey">(559495423fd5b8ad6450234a89902f0f1896cd8c)</span></li>
<li>src/lib/marble/GnomonicScanlineTextureMapper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/webpopup/icon-panorama.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-qt/QtMainWindow.cpp <span style="color: grey">(d7beaff0a4758ab7bc752289549e88a6d173359a)</span></li>
<li>src/apps/marble-ui/ControlView.h <span style="color: grey">(5cb75a59880b5b25f12fd12bc6fc0976fb06efa4)</span></li>
<li>src/apps/marble-ui/ControlView.cpp <span style="color: grey">(fdc66d5b735a9f526582176b29471f0ea673066c)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(532ec3d3e63bd78e06600f0c11a2ee653f56a721)</span></li>
<li>src/lib/marble/FileStoragePolicy.h <span style="color: grey">(aaff71a2c3e40e618d5370d463e4a9edab55011f)</span></li>
<li>src/lib/marble/projections/AzimuthalProjection_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/AzimuthalProjection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/AzimuthalProjection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/layers/TextureLayer.cpp <span style="color: grey">(845b032c7b7603af5af0bdb9064b01e0a0817af3)</span></li>
<li>src/lib/marble/libmarble.qrc <span style="color: grey">(ea7c956750700d4b7db01974ea79d8a9362afc06)</span></li>
<li>src/lib/marble/layers/GeometryLayer.cpp <span style="color: grey">(fbfe9a379ef6308d065d00b9b75188e8b33f1054)</span></li>
<li>src/lib/marble/layers/PopupLayer.h <span style="color: grey">(8f9fcc66c8a6def5249757d7f17c22427aa87699)</span></li>
<li>src/lib/marble/layers/PopupLayer.cpp <span style="color: grey">(b7abd977eb140add867b7b347242d636e8c1c757)</span></li>
<li>src/lib/marble/webpopup/photooverlay.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/SphericalProjection.cpp <span style="color: grey">(669851ee72d89a128814de8e7575d6db4ce5db15)</span></li>
<li>src/plugins/render/speedometer/Speedometer.h <span style="color: grey">(7ecbc57f064beca11d34003ee22703f9b5485f78)</span></li>
<li>src/plugins/render/speedometer/Speedometer.cpp <span style="color: grey">(f374d9d5a7a58e886917f9d27c2d85ec1b57798c)</span></li>
<li>src/plugins/render/stars/StarsPlugin.h <span style="color: grey">(341e3f01835029c4976379c29c1a4ab05444d64c)</span></li>
<li>src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(cf59abfec13c491cec108f024bda6a94eeae0275)</span></li>
<li>src/plugins/render/sun/SunPlugin.h <span style="color: grey">(a47d2a427de6b6750ce43dd39aeddba463eecdcb)</span></li>
<li>src/plugins/render/sun/SunPlugin.cpp <span style="color: grey">(b03fac2c195ad0e532132ef0c20e7385f9ce522a)</span></li>
<li>src/plugins/render/weather/WeatherPlugin.h <span style="color: grey">(3020d3ff461641095e274cfeb35cba648904c9e7)</span></li>
<li>src/plugins/render/weather/WeatherPlugin.cpp <span style="color: grey">(2d3b6194a1d9d09807ce30a2c0b13e2842e146bb)</span></li>
<li>src/plugins/render/wikipedia/WikipediaPlugin.h <span style="color: grey">(71471b7d666bc6cd9c6fc0948b976e8d14baf929)</span></li>
<li>src/plugins/render/wikipedia/WikipediaPlugin.cpp <span style="color: grey">(2777f7bc2bb72dfa85f6deeff1b86f0ecf720b9b)</span></li>
<li>src/plugins/render/progress/ProgressFloatItem.h <span style="color: grey">(31d491dffdb264c51d043a2cf45ff8b74872a701)</span></li>
<li>src/plugins/render/progress/ProgressFloatItem.cpp <span style="color: grey">(314c7b835995859f5bb053c284af734bea4a2f8b)</span></li>
<li>src/plugins/render/routing/RoutingPlugin.h <span style="color: grey">(72537e181406486af283e6bbb58b79ca7c690a94)</span></li>
<li>src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(3881c9ece7ff500d1ef383bb37ef0c5f7cac2f55)</span></li>
<li>src/plugins/render/satellites/SatellitesPlugin.h <span style="color: grey">(7b822e563187326066003a625e9f34ddc6a633ee)</span></li>
<li>src/plugins/render/satellites/SatellitesPlugin.cpp <span style="color: grey">(d5c8a647fb15266daae11914b1c4e099a0cc245b)</span></li>
<li>src/plugins/declarative/MarbleDeclarativeWidget.cpp <span style="color: grey">(0cb6c94d584f385317caa8e88f19fbfec57a5a95)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.h <span style="color: grey">(8d459e8eade88b337a3207f1a496606bd104647e)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.cpp <span style="color: grey">(e62816725c884b8b0a8ae18ee4c4862be909041a)</span></li>
<li>src/plugins/render/aprs/AprsPlugin.h <span style="color: grey">(4a2758a5e25906250c019e0125b3b5efe5fe1203)</span></li>
<li>src/plugins/render/aprs/AprsPlugin.cpp <span style="color: grey">(2485a30b115571f1ea0ff6b885cb8710b4ee53cd)</span></li>
<li>src/plugins/render/atmosphere/AtmospherePlugin.h <span style="color: grey">(2294398a6dfda67a82d008480d02d86f19ea7609)</span></li>
<li>src/plugins/render/atmosphere/AtmospherePlugin.cpp <span style="color: grey">(492c1113221810989ed28d7c73a19d18363db2ea)</span></li>
<li>src/plugins/render/compass/CompassFloatItem.h <span style="color: grey">(ae155dfa8387afbc2be6af6ee20d4784f1440727)</span></li>
<li>src/plugins/render/compass/CompassFloatItem.cpp <span style="color: grey">(a674f51695b0f7345d546336fbd1ebb98b02ae7d)</span></li>
<li>src/plugins/render/crosshairs/CrosshairsPlugin.h <span style="color: grey">(543f1c393fb03da64dba9b28d0270eee95582cca)</span></li>
<li>src/plugins/render/crosshairs/CrosshairsPlugin.cpp <span style="color: grey">(c6274291ae1acb9583ac10342de0cd332dd1fc9d)</span></li>
<li>src/plugins/render/earthquake/EarthquakePlugin.h <span style="color: grey">(1cb88b710798d31eb29ecb21b9c9744830a5e8a6)</span></li>
<li>src/plugins/render/earthquake/EarthquakePlugin.cpp <span style="color: grey">(47f041c8e3f40d19d151ff219b6f7ed9e2506ad1)</span></li>
<li>src/plugins/render/eclipses/EclipsesPlugin.h <span style="color: grey">(8756d4652680d66f895bee0e9803c088538a2779)</span></li>
<li>src/plugins/render/eclipses/EclipsesPlugin.cpp <span style="color: grey">(459c870e6edc18df552f7e712df4978ac08ae547)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.h <span style="color: grey">(db66ae1f829c88be1d5908cd442dca9e88962853)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp <span style="color: grey">(db4113cda16733e709a820f1aa2ddc1681219c80)</span></li>
<li>src/plugins/render/elevationprofilemarker/ElevationProfileMarker.h <span style="color: grey">(39e6847d9b2a2704c7ded36ad76f99e7ace48195)</span></li>
<li>src/plugins/render/elevationprofilemarker/ElevationProfileMarker.cpp <span style="color: grey">(c453e8c51d5131d887f0c9ec7fae24aa108b28c3)</span></li>
<li>src/plugins/render/foursquare/FoursquarePlugin.h <span style="color: grey">(19f3e7d734568f419e7023b754c896debaac875a)</span></li>
<li>src/plugins/render/foursquare/FoursquarePlugin.cpp <span style="color: grey">(dbc4928394ea06435853b1a78545d5d0708425f1)</span></li>
<li>src/plugins/render/gpsinfo/GpsInfo.h <span style="color: grey">(76dc01b8f565122812f1f74476a4a080e8f1661f)</span></li>
<li>src/plugins/render/gpsinfo/GpsInfo.cpp <span style="color: grey">(e3d8f492db4a92658b0757f150b0032f1871402a)</span></li>
<li>src/plugins/render/graticule/GraticulePlugin.h <span style="color: grey">(e48cb422cb6ffd89658c0581a3b0b446d5822f5f)</span></li>
<li>src/plugins/render/graticule/GraticulePlugin.cpp <span style="color: grey">(a5e6d14a921c66d55cf01e39b16564dedcf6532b)</span></li>
<li>src/plugins/render/license/License.h <span style="color: grey">(74be899318a786b5bb352a29a4e61b810290abf6)</span></li>
<li>src/plugins/render/license/License.cpp <span style="color: grey">(4470f14bef791ea21d3ce60d0a21848f0981ed13)</span></li>
<li>src/plugins/render/mapscale/MapScaleFloatItem.h <span style="color: grey">(4a0f922594ba6a23bff69f038e26c8baaa3f6472)</span></li>
<li>src/plugins/render/mapscale/MapScaleFloatItem.cpp <span style="color: grey">(ea869bbe0b946e33eacc0cb7246c28c315cecc16)</span></li>
<li>src/plugins/render/measure/MeasureToolPlugin.h <span style="color: grey">(2c2c27b8ed8ad9b7a959b4dc297c5f55173b362a)</span></li>
<li>src/plugins/render/measure/MeasureToolPlugin.cpp <span style="color: grey">(689c8b1ca9ad59eacf8d73291479fbd5c20e34db)</span></li>
<li>src/plugins/render/navigation/NavigationFloatItem.h <span style="color: grey">(14cdcaa7093e695a6cb62572f0cbfca243bc59fa)</span></li>
<li>src/plugins/render/navigation/NavigationFloatItem.cpp <span style="color: grey">(47b057001e4661e669e5ade78206c55993eede9d)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComPlugin.h <span style="color: grey">(16d75eb6dff8650b21c1cea2927b224c8e04e028)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComPlugin.cpp <span style="color: grey">(45a92f25f3fa85729bfdd19c199eabb2d49d977a)</span></li>
<li>src/plugins/render/opendesktop/OpenDesktopPlugin.h <span style="color: grey">(2998c2d451697bd26e70c4f1128cc6a2c2904a8c)</span></li>
<li>src/plugins/render/opendesktop/OpenDesktopPlugin.cpp <span style="color: grey">(f54fd1442fc38da8642f5fb0b7e4e68f8841b978)</span></li>
<li>src/plugins/render/overviewmap/OverviewMap.h <span style="color: grey">(4c9ada8ebf411b23ac4df641a3a2c5e28004ac08)</span></li>
<li>src/plugins/render/overviewmap/OverviewMap.cpp <span style="color: grey">(1408261ea4b6cc34ff59060a5af37a6c25365e2e)</span></li>
<li>src/plugins/render/photo/PhotoPlugin.h <span style="color: grey">(63d11eb386233fa7ec6fb8aa480037ef6f7f5fe9)</span></li>
<li>src/plugins/render/photo/PhotoPlugin.cpp <span style="color: grey">(4076a18a285944efc5f3ad9075031e54ee7bfac4)</span></li>
<li>src/plugins/render/positionmarker/PositionMarker.h <span style="color: grey">(cf2459962dfba33005bc7e7ed3b38b0f12c4d116)</span></li>
<li>src/plugins/render/positionmarker/PositionMarker.cpp <span style="color: grey">(45f20c54b517b6bafe26d72b6534eb7c9f66b97c)</span></li>
<li>src/plugins/render/postalcode/PostalCodePlugin.h <span style="color: grey">(caa8930e727ce88bf360b195825ece880f619731)</span></li>
<li>src/plugins/render/postalcode/PostalCodePlugin.cpp <span style="color: grey">(87feacdd8035289206da30ff2596844e4e9a2c67)</span></li>
<li>src/lib/marble/projections/GnomonicProjection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/GnomonicProjection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/SphericalProjection.h <span style="color: grey">(865407da4e67a6bcdc07fb7bb83ab5f4e7ab7a20)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119903/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>