<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119538/">https://git.reviewboard.kde.org/r/119538/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wow, that sounds terrific! Wouldn't have thought, that this would be possible this soon :)</p></pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On Juli 29th, 2014, 4:32 nachm. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Juli 29, 2014, 4:32 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is the next step toward the photoOverlay viewer. It includes the gnomonic projection code of shentey from https://github.com/shentok/marble/tree/streetview/src.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The basic things what have been done:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- Now multiple MarbleWidget can be present at the same time, this is controlled by the ControlView<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- The MapThemeManager can create a working mapTheme from a GeoDataPhotoOverlay<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- The needed resources for the image viewer are stored in a temporary directory</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Known bugs:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- Can't turn off the plugins (e.g. compass, map-overview, grid, ...) with the properties in the GeoSceneDocument (cause currently unknown)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- The new widget doesn't get the focus despite the invoke of setFocus()</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/bitmaps/webpopup/icon-panorama.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-ui/ControlView.h <span style="color: grey">(cea9dc04926330222faaa8b729963a0bf7bba43c)</span></li>
<li>src/apps/marble-ui/ControlView.cpp <span style="color: grey">(31294fc145b6244a0e1d1aa053a052f8dfdb947d)</span></li>
<li>src/lib/marble/MarbleWidget.h <span style="color: grey">(dfc1aa7bc8004e96a7759d06165580bf8c56b63c)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(d4c7ff48145bd55de23cf0a0e4a2b92e8037bb29)</span></li>
<li>src/lib/marble/MarbleWidgetPopupMenu.cpp <span style="color: grey">(1dc7760903f4899e830d754957651c6681172971)</span></li>
<li>src/lib/marble/PopupItem.h <span style="color: grey">(4c65004d1386305c3394f5b343bc67cff9127f39)</span></li>
<li>src/lib/marble/PopupItem.cpp <span style="color: grey">(a4e973ad60a2a8dd24fc5370b6eaf95b247f5bb5)</span></li>
<li>src/lib/marble/RenderPlugin.h <span style="color: grey">(67472fa005f191c823f188848926f87150ba9c98)</span></li>
<li>src/lib/marble/RenderPlugin.cpp <span style="color: grey">(1f2e9b1f679914a96337042fd6d9b347dac2533e)</span></li>
<li>src/lib/marble/TileCreator.cpp <span style="color: grey">(e54a62e42faa940fbe3cb255ae2a03bba702d70b)</span></li>
<li>src/lib/marble/ViewportParams.cpp <span style="color: grey">(d6cf03603b353671f52440adcea15ddecf188b94)</span></li>
<li>src/lib/marble/WebPopupWidget.ui <span style="color: grey">(8cf7103185281833924b0e36da655b2fbe19b8b6)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPhotoOverlay.cpp <span style="color: grey">(5a3cbc3f59960e5a23f410be45837b4d17be16b2)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPlacemark.h <span style="color: grey">(96028e426a9688ffbb48cf8942eba2455a06b581)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPlacemark.cpp <span style="color: grey">(b2d0304ec10e2243538cf1cdb252c2da7f0cde5c)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPlacemark_p.h <span style="color: grey">(b4c1ee1a7f53d596baada68c94bba72cb26a9e53)</span></li>
<li>src/lib/marble/geodata/graphicsitem/GeoPhotoGraphicsItem.cpp <span style="color: grey">(4fab8fb25528706527e9138d10a4850c20025437)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneDocument.h <span style="color: grey">(2c12be288f06a1384704a5b63721001a9c0086be)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneDocument.cpp <span style="color: grey">(6c36b0a66392600624b2371693e8e3ebcd027401)</span></li>
<li>src/lib/marble/layers/GeometryLayer.h <span style="color: grey">(8d86aed059f7d6e36fd668bedb1f26d467cd2887)</span></li>
<li>src/lib/marble/layers/GeometryLayer.cpp <span style="color: grey">(fbfe9a379ef6308d065d00b9b75188e8b33f1054)</span></li>
<li>src/lib/marble/layers/PopupLayer.h <span style="color: grey">(8f9fcc66c8a6def5249757d7f17c22427aa87699)</span></li>
<li>src/lib/marble/layers/PopupLayer.cpp <span style="color: grey">(b7abd977eb140add867b7b347242d636e8c1c757)</span></li>
<li>src/lib/marble/layers/TextureLayer.cpp <span style="color: grey">(845b032c7b7603af5af0bdb9064b01e0a0817af3)</span></li>
<li>src/lib/marble/libmarble.qrc <span style="color: grey">(4ff9bf7cd37241ba879d332104d4418a7ac60836)</span></li>
<li>src/lib/marble/projections/GnomonicProjection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/GnomonicProjection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/webpopup/photooverlay.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/declarative/MarbleDeclarativeWidget.cpp <span style="color: grey">(0cb6c94d584f385317caa8e88f19fbfec57a5a95)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(d9e94b5ec2f552827258152445abc962a463dea9)</span></li>
<li>src/lib/marble/FileStoragePolicy.h <span style="color: grey">(aaff71a2c3e40e618d5370d463e4a9edab55011f)</span></li>
<li>src/lib/marble/FileStoragePolicy.cpp <span style="color: grey">(559495423fd5b8ad6450234a89902f0f1896cd8c)</span></li>
<li>src/lib/marble/GnomonicScanlineTextureMapper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/GnomonicScanlineTextureMapper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MapThemeManager.h <span style="color: grey">(d18c8de6ec29153e00d079a4b30579ca1d9be14d)</span></li>
<li>src/lib/marble/MapThemeManager.cpp <span style="color: grey">(ac40bed18c50aac1e2d90c89bd271b80124970a6)</span></li>
<li>src/lib/marble/MarbleGlobal.h <span style="color: grey">(69a96f3badc69edc36a0163a173f7214fe71aeb5)</span></li>
<li>src/lib/marble/MarbleMap.cpp <span style="color: grey">(25007ac7921df3ca447eb587e9d12ffc838e6856)</span></li>
<li>src/lib/marble/MarbleModel.h <span style="color: grey">(9643186b62429a4e04f421030d64b8ab86cd7f7c)</span></li>
<li>src/lib/marble/MarbleModel.cpp <span style="color: grey">(d240bacb24fd25c84d7dc5646c3264d854840841)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119538/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>