<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119391/">https://git.reviewboard.kde.org/r/119391/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On Juli 21st, 2014, 10:09 nachm. UTC, Cruceru Calin-Cristian wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<p style="color: grey;"><i>Updated Juli 21, 2014, 10:09 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As the title says, this patch includes changes for adding a small animation when two nodes are being merged. Before, the merging was a little bit too 'fast' and it could have confused the users. I think that this way, the merging is much nicer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, you will see in this patch a couple of other small changes which I decided to make after I discovered a couple of bugs. For example one could not interact with the map anymore after selecting the second node to be merged because in AnnotatePlugin, at each mouse press, the item got selected for moving and deselected at mouse release, but when selecting the second node to be merged, the release event was not caught by the item.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I need your feedback regarding the way the new feature behaves :).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/annotate/AreaAnnotation.cpp <span style="color: grey">(e0ed211)</span></li>
<li>src/plugins/render/annotate/CMakeLists.txt <span style="color: grey">(4792a78)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.cpp <span style="color: grey">(cc25874)</span></li>
<li>src/plugins/render/annotate/MergingNodesAnimation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/MergingNodesAnimation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.h <span style="color: grey">(6bb9b61)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.cpp <span style="color: grey">(dd403e6)</span></li>
<li>src/plugins/render/annotate/AreaAnnotation.h <span style="color: grey">(6c305fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119391/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>