<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117188/">https://git.reviewboard.kde.org/r/117188/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Abhinav Gangwar.</div>
<p style="color: grey;"><i>Updated July 15, 2014, 7:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have fixed the two tests which failed due to the commit 798be2a0c27a2058e497eb2409fbb38cf7148a22 .
1. First test, TestGeoDataWriter, was faling because : In KmlSimpleDataTagWriter and KmlSchemaDataTagWriter I was passing wrong
namespace ( kml::kmlTag_nameSpace22 ) to static GeoTagWriterRegistrar s_writerSimpleData(...) . I just changed that to
kml::kmlTag_nameSpaceOgc22 and it worked fine.
2. Sorry, I have been unable to put my point on why TestGeoDataTrack failed. So, I have written detailed descrption at
http://paste.kde.org/pfetilhpe . Hope that helps. :)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added support for kml tag SchemaData and its child element SimpleData.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works fine on my system</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataExtendedData.cpp <span style="color: grey">(1fb41bd)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSchemaData.h <span style="color: grey">(4c444b0)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSchemaData.cpp <span style="color: grey">(c834c72)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlSimpleArrayDataTagHandler.cpp <span style="color: grey">(616e6b9)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSchemaDataTagWriter.cpp <span style="color: grey">(97d3acc)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSimpleDataTagWriter.cpp <span style="color: grey">(1f79f94)</span></li>
<li>tests/data/schemaData.kml <span style="color: grey">(df01536)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117188/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>