<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118887/">https://git.reviewboard.kde.org/r/118887/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 28th, 2014, 9:38 a.m. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Another approach we could go for is not using a dock widget for the contents, but instead have the popup behave similar to what you propose: It's contents stick to some specified screen position (on top of the map) and only the arrow tip follows the coordinate.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was more looking for a solution that 1) does not cover the map and 2) which makes use of the look and feel of the toolkit. In particular, I like the clean separation of the map on one side and the web view on the other. In addition, I like that the sizes can be changed by resizing the main window and that the view's ratio can be changed via a standard control, the splitter. For me it's important that both the map and the web view get their deserved sizes because both show rather complex information.
I agree with Torsten, however, that the visual appearance needs to be improved, which was one big reason I've set up this review request. Any suggestions?</pre>
<br />
<p>- Bernhard</p>
<br />
<p>On June 22nd, 2014, 7:54 p.m. UTC, Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated June 22, 2014, 7:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Viewing placemark information such as Wikipedia articles is currently done via a floating dialog. While it apprears quite
stylish, it covers nearby items such that they can't be clicked or it is moved out of scope when the globe is rotated.
These two properties of the floating dialog get in the way when exploring the world.
To improve the browsing experience, a dock widget containting a web view is used. In order to visually associate the view
with an item, a thin line is drawn between them. This improves the browsing experience since the dock widget always remembers
the last position and size no matter how the user scrolls around or clicks different items. It also doesn't cover nearby
items. As a result, exploring Wikipedia articles and photos is much more addictive.
This patch is still work in progress. As such, it has of course issues such as the line being always drawn or the line not
following the corner of the dock widget. Still, I want to get feedback if the general direction is right. Also, the dock
widget should probably only be used for detailed placemark information, but not e.g. for balloon-style information. Note that
even if I temporarily abused the PopupLayer to power the dock widget, I don't intend to remove PopupItem altogether (it could
still show balloon-style information).
I'm looking forward to your feedback!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-ui/ControlView.h <span style="color: grey">(cea9dc04926330222faaa8b729963a0bf7bba43c)</span></li>
<li>src/apps/marble-ui/ControlView.cpp <span style="color: grey">(31294fc145b6244a0e1d1aa053a052f8dfdb947d)</span></li>
<li>src/lib/marble/MarbleWebView.h <span style="color: grey">(d564111586a25148a8391767c4f210e83f153951)</span></li>
<li>src/lib/marble/MarbleWebView.cpp <span style="color: grey">(b67a7fbc95642b93455c2f0717ac4b31d181e7af)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(d4c7ff48145bd55de23cf0a0e4a2b92e8037bb29)</span></li>
<li>src/lib/marble/MarbleWidgetPopupMenu.cpp <span style="color: grey">(1dc7760903f4899e830d754957651c6681172971)</span></li>
<li>src/lib/marble/layers/PopupLayer.h <span style="color: grey">(ff18366c6b808f051cafa1ba3279f1f9b75c8109)</span></li>
<li>src/lib/marble/layers/PopupLayer.cpp <span style="color: grey">(0bc58cd4f10f377e39fbf5b9ddfaafddccb60956)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118887/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/f848fcc8-8324-49d9-b550-b420a6e7e074__PopupDock.png">docked info widget in action</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>