<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118681/">https://git.reviewboard.kde.org/r/118681/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to update the code by using the new renderStatus property. But right now calling "m_model->addGeoDataFile(path);" does not have any effect on that property, m_marbleMap->renderStatus() has the same value after the call and before. Also is no renderStatusChanged signal emitted.
So no update yet of this patch.
So what is the plan with this RR now? :)
</pre>
<br />
<p>- Friedrich W. H. Kossebau</p>
<br />
<p>On June 12th, 2014, 12:33 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 12, 2014, 12:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As inspired by https://git.reviewboard.kde.org/r/118618/ I brushed up the thumbnailing code I drafted almost 2 years ago in the train on my way back from the Marble sprint in Prague. A shame I did not do that earlier.
It is another example where renderer state would be good to know. The current approach works more or less. Now and then no thumbnail is created, have yet to find out when this happens. And in the attached sample screenshot the New York KML files are for some reason not correctly zoomed in some thumbnails. Should be a useful testbed for the render status work. But IMHO good enough for a merge already.
The thumbnailer is only built in non-Qt-only mode. The service desktop files are installed for each geo data file type from the respective runner plugin sources, following the pattern of the App/KPart service desktop files.
Future improvements will be to make it configurable which map theme to use (now hardcoded to "earth/openstreetmap/openstreetmap.dgml"). Might get interesting for non-earth geo data files :) surely needs some more input from the experts.
Not sure if thumbnails should be cached or not. Set it to "true" for now. Sadly this cannot be controlled case-by-case (e.g. if thumbnail has lower quality due to missing map theme data).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Enabled previews for the geo data files (Dolphin > Preferences > General > Previews) and browsed all kind of folders with geo data files.
To get rid of cached thumbnails do "rm ~/.thumbnails/ -r" or set CacheThumbnail=false in the desktop service files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(d7ea7b1)</span></li>
<li>src/plugins/runner/gpx/CMakeLists.txt <span style="color: grey">(460c43a)</span></li>
<li>src/plugins/runner/gpx/marble_thumbnail_gpx.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/kml/CMakeLists.txt <span style="color: grey">(f964a85)</span></li>
<li>src/plugins/runner/kml/marble_thumbnail_kml.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/kml/marble_thumbnail_kmz.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/CMakeLists.txt <span style="color: grey">(392b2cf)</span></li>
<li>src/plugins/runner/osm/marble_thumbnail_osm.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/shp/CMakeLists.txt <span style="color: grey">(ccc0c9d)</span></li>
<li>src/plugins/runner/shp/marble_thumbnail_shp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/thumbnailer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/thumbnailer/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/thumbnailer/thumbnailer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/thumbnailer/thumbnailer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118681/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/12/5503799d-318e-45d7-856c-6d505d8c95c6__thumbnails.png">Thumbnails in KML example folder</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>