<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118766/">https://git.reviewboard.kde.org/r/118766/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 16th, 2014, 3:23 p.m. EEST, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some UI thoughts since you asked for them in your blog :)
- what about using the ShowAlphaChannel option of QColorDialog instead of having an additional slider?
- the color selection controls could be merged into something like this
Fill Color: [drop down or list view with entries]
* No Color
* some blue color (from oxygen palette)
* some red color (from oxygen palette)
* some purple color (from oxygen palette)
* ...
* custom color (triggers color dialog)
- it might be nice to use a modeless dialog (non blocking, use open() instead of exec()) with an Apply button so the user can leave the dialog open toggle through the options quickly
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you very much for your suggestions. It really helps me to develop a better vision on how things would be nice to look.
I redesigned the UI taking into consideration the first thing you mentioned. However, I did not (yet) applied the changes from your second point from several reasons:
- I wanted to make sure it looks good so far taking into consideration that I modified it according to your first and third point;
- I also want to see tackat's opinion on this.</pre>
<br />
<p>- Cruceru</p>
<br />
<p>On June 15th, 2014, 9:51 p.m. EEST, Cruceru Calin-Cristian wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Cruceru Calin-Cristian.</div>
<p style="color: grey;"><i>Updated June 15, 2014, 9:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I added a pretty simple customization option for drawn polygons which includes the following:
- polygon area/lines color and opacity modifying;
- lines width modifying;
- polygon area filling can be set to "Not Filled".
Waiting for suggestions on what else would be nice to have as well as remarks about this implementation.
PS: It is what I have been working on for the last two days, so there is not too much code, but I think it is better than submitting large patches as I did last time.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It works very nice.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/annotate/AnnotatePlugin.h <span style="color: grey">(a401714)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.cpp <span style="color: grey">(2aca70e)</span></li>
<li>src/plugins/render/annotate/AreaAnnotation.cpp <span style="color: grey">(1a4452b)</span></li>
<li>src/plugins/render/annotate/CMakeLists.txt <span style="color: grey">(6caa034)</span></li>
<li>src/plugins/render/annotate/EditGroundOverlayDialog.ui <span style="color: grey">(9873e8c)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118766/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>