<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118717/">https://git.reviewboard.kde.org/r/118717/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118717/diff/2/?file=280751#file280751line122" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/graphicsview/GeoGraphicsItem.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class MARBLE_EXPORT GeoGraphicsItem</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">123</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">setHighlight</span><span class="p">(</span> <span class="kt">bool</span> <span class="n">isHighlight</span><span class="p">,</span> <span class="n">QColor</span> <span class="n">highlightColor</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do we really need to have the highlightColor as a second parameter here? :) Why not just keep it in GeoSceneMap?
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118717/diff/2/?file=280752#file280752line106" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/graphicsview/GeoGraphicsItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void GeoGraphicsItem::setStyle( const GeoDataStyle* style )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">106</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">GeoGraphicsItem</span><span class="o">::</span><span class="n">setHighlight</span><span class="p">(</span><span class="kt">bool</span> <span class="n">isHighlight</span><span class="p">,</span> <span class="n">QColor</span> <span class="n">highlightColor</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it should be "setHighlighted( bool )" like:
void QGraphicsItem::setSelected ( bool selected )
</pre>
</div>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On June 13th, 2014, 6:40 a.m. UTC, Abhinav Gangwar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Abhinav Gangwar.</div>
<p style="color: grey;"><i>Updated June 13, 2014, 6:40 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Modifications:
1. Modified Pn2Runner so that it now handles MULTIGEOMETRY also ( we can now ignore https://git.reviewboard.kde.org/r/118620/ ) .
2. Added support to specify highlight color in dgml file.
3. Highlighting is done the following way:
-> Input handler emits mouseClickGeoPostion( qreal lon, qreal lat, GeoDataCoordinates::Unit unit ) whenever a click is detected on map.
-> Signal mouseClickGeoPostion() is connected to the slot MarbleModel::handleClick() .
-> Also, GeoGraphicsItem contains a member 'bool m_isHighlightStyle' which is true whenever highlight style should be used otherwise use normal.
-> MarbleModel::handleClick() processes the coordinates and finds which placemarks ( in different layers ) they belong to. It further emits
signal announceHighlight( QVector<GeoDataPlacemark *>, QColor) . Vector contains all the placemarks which are under mouse . The QColor
here is the highlight color. Highlight color is specified in <map> tag as its attribute in dgml file.
-> The slot GeoSceneGraphics::applyHighlight() is connected to MarbleModel::announceHighlight() signal .
-> In GeoSceneGraphics we find QList<TileId> for a feature, which is detected under mouse , from GeoSceneGraphics::m_features and then for every
TileId we find QList<GeoGraphicsItem*> and then set GeoGraphicsItem::m_isHighlight true for all items which have
GeoGraphicsItem::m_feature equal to clicked placemark.
-> Modify GeoGraphicsItem::style() so that it returns appropriate style on basis of GeoGraphicsItem::m_isHighlight .
That's it . Need feedback :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/maps/earth/political/political.dgml <span style="color: grey">(abfb8d9)</span></li>
<li>data/naturalearth/ne_10m_admin_0_boundary_lines_land.pn2 <span style="color: grey">(37d4033)</span></li>
<li>data/naturalearth/ne_10m_rivers_lake_centerlines.pn2 <span style="color: grey">(01c764c)</span></li>
<li>data/naturalearth/ne_50m_admin_0_boundary_lines_land.pn2 <span style="color: grey">(f01c4cd)</span></li>
<li>data/naturalearth/ne_50m_admin_0_boundary_lines_maritime_indicator.pn2 <span style="color: grey">(029a94e)</span></li>
<li>data/naturalearth/ne_50m_admin_0_breakaway_disputed_areas.pn2 <span style="color: grey">(22a9b64)</span></li>
<li>data/naturalearth/ne_50m_admin_0_countries.pn2 <span style="color: grey">(a982356)</span></li>
<li>data/naturalearth/ne_50m_admin_0_pacific_groupings.pn2 <span style="color: grey">(4e3146a)</span></li>
<li>data/naturalearth/ne_50m_admin_1_states_provinces_lines.pn2 <span style="color: grey">(3e81207)</span></li>
<li>data/naturalearth/ne_50m_antarctic_ice_shelves_lines.pn2 <span style="color: grey">(b18610c)</span></li>
<li>data/naturalearth/ne_50m_antarctic_ice_shelves_polys.pn2 <span style="color: grey">(f45940f)</span></li>
<li>data/naturalearth/ne_50m_coastline.pn2 <span style="color: grey">(1c1326e)</span></li>
<li>data/naturalearth/ne_50m_glaciated_areas.pn2 <span style="color: grey">(6112136)</span></li>
<li>data/naturalearth/ne_50m_lakes.pn2 <span style="color: grey">(e30a90e)</span></li>
<li>data/naturalearth/ne_50m_lakes_historic.pn2 <span style="color: grey">(2ac5be6)</span></li>
<li>data/naturalearth/ne_50m_land.pn2 <span style="color: grey">(67baf68)</span></li>
<li>data/naturalearth/ne_50m_playas.pn2 <span style="color: grey">(f1abfe0)</span></li>
<li>data/naturalearth/ne_50m_rivers_lake_centerlines.pn2 <span style="color: grey">(05b91fa)</span></li>
<li>data/naturalearth/ne_50m_urban_areas.pn2 <span style="color: grey">(fbfb15a)</span></li>
<li>src/lib/marble/GeoGraphicsScene.h <span style="color: grey">(869c3d8)</span></li>
<li>src/lib/marble/GeoGraphicsScene.cpp <span style="color: grey">(f84c532)</span></li>
<li>src/lib/marble/MarbleInputHandler.h <span style="color: grey">(58107e5)</span></li>
<li>src/lib/marble/MarbleInputHandler.cpp <span style="color: grey">(3fce19a)</span></li>
<li>src/lib/marble/MarbleMap.cpp <span style="color: grey">(0e1c70d)</span></li>
<li>src/lib/marble/MarbleModel.h <span style="color: grey">(9643186)</span></li>
<li>src/lib/marble/MarbleModel.cpp <span style="color: grey">(2c56476)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(d58db8e)</span></li>
<li>src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.cpp <span style="color: grey">(b161d06)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h <span style="color: grey">(cf4dd76)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp <span style="color: grey">(85f10fb)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlMapTagHandler.cpp <span style="color: grey">(fb7ff0f)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneMap.h <span style="color: grey">(498bb3a)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneMap.cpp <span style="color: grey">(7f94c11)</span></li>
<li>src/lib/marble/graphicsview/GeoGraphicsItem.h <span style="color: grey">(653fef0)</span></li>
<li>src/lib/marble/graphicsview/GeoGraphicsItem.cpp <span style="color: grey">(1227316)</span></li>
<li>src/lib/marble/graphicsview/GeoGraphicsItem_p.h <span style="color: grey">(618cddf)</span></li>
<li>src/lib/marble/layers/GeometryLayer.h <span style="color: grey">(f868f26)</span></li>
<li>src/lib/marble/layers/GeometryLayer.cpp <span style="color: grey">(daea513)</span></li>
<li>src/plugins/runner/pn2/Pn2Runner.h <span style="color: grey">(520b367)</span></li>
<li>src/plugins/runner/pn2/Pn2Runner.cpp <span style="color: grey">(74fa848)</span></li>
<li>src/plugins/runner/shp/ShpRunner.cpp <span style="color: grey">(0ec98dc)</span></li>
<li>tools/shp2pn2/shp2pn2.cpp <span style="color: grey">(639b30f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118717/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/e541a355-80be-40a8-8158-afea0677bd0e__pn2DataNew.zip">pn2DataNew.zip</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/f04644e8-6318-4b9a-a8d1-2747b405f73b__color10.png">color10.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/5f07bac3-3bcb-4086-b8d6-5b836b8f18dc__color11.png">color11.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>