<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118495/">https://git.reviewboard.kde.org/r/118495/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Dennis Nienhüser.</div>
<div>By Adam Dabrowski.</div>
<p style="color: grey;"><i>Updated June 3, 2014, 12:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Functionalities:
- Mouse, touch and pinch input handling for MarbleQuickItem (keyboard was enabled earlier)
Other changes:
- Refactored input handling to reuse code, broke into smaller pieces (functions)
- Extended the example (marbleQuick2)
Known issues:
- Some refactoring still should be done around input classes
- Inertial rotation is disabled by default in MarbleQuickItem because of some issues (mostly touch-related). However, issues are rather minor so feel free to enable it back.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Using these changes since some time in a working app that is based on a MarbleQuickItem subclass (on both unix PC and a touch device)
- Built and run marbleQuick2 example on both PC and a touch device.
- Did good tests for MarbleQuickItem, basic regression testing for MarbleWidget and no testing for Qt4.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>examples/cpp/marbleQuick2/main.cpp <span style="color: grey">(640baa6)</span></li>
<li>examples/cpp/marbleQuick2/main.qml <span style="color: grey">(76947ed)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(4add26b)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.h <span style="color: grey">(7c047ed)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.cpp <span style="color: grey">(98855bb)</span></li>
<li>src/lib/marble/MarbleInputHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleInputHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleQuickItem.h <span style="color: grey">(8fd5657)</span></li>
<li>src/lib/marble/MarbleQuickItem.cpp <span style="color: grey">(0ccc0ac)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(acc270a)</span></li>
<li>src/lib/marble/MarbleWidgetInputHandler.h <span style="color: grey">(f763d1e)</span></li>
<li>src/lib/marble/MarbleWidgetInputHandler.cpp <span style="color: grey">(912c12d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118495/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>