<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118203/">https://git.reviewboard.kde.org/r/118203/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 27th, 2014, 5:39 p.m. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still need two changes in MarbleAbstractPresenter.cpp here in order to compile/link it with Qt 4.8:
1) Change the QtMath include to
#if QT_VERSION >= 0x050000
#include <QtMath>
#else
#include <qmath.h>
#endif
2) Include the moc file
#include "MarbleAbstractPresenter.moc"
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done</pre>
<br />
<p>- Adam</p>
<br />
<p>On May 28th, 2014, 6:19 a.m. UTC, Adam Dabrowski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Adam Dabrowski.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 6:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A first step to port Marble to Qt Quick 2.0
Extracted most of QWidget-independent implementation code from MarbleWidget into MarbleAbstractPresenter
Adjusted MarblePhysics as an example of a port for a class that formerly used MarbleWidget
Wrote a stub QQuickItem class. This was tested with QML 2.0 and works (displays maps and reacts to keyboard input).
Still a work in progress, but a chunk that can be pushed without breaking anything.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using attached app.
Also did a regression tests for MarbleWidget (simple ones)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>examples/cpp/CMakeLists.txt <span style="color: grey">(98a1ae4)</span></li>
<li>examples/cpp/marbleQuick2/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>examples/cpp/marbleQuick2/CMakeLists.txt.external <span style="color: grey">(PRE-CREATION)</span></li>
<li>examples/cpp/marbleQuick2/Readme.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>examples/cpp/marbleQuick2/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>examples/cpp/marbleQuick2/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(5b4a0ee)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleAbstractPresenter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarblePhysics.h <span style="color: grey">(8559809)</span></li>
<li>src/lib/marble/MarblePhysics.cpp <span style="color: grey">(9c4b112)</span></li>
<li>src/lib/marble/MarbleQuickItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleQuickItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(10b466e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118203/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>