<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118011/">https://git.reviewboard.kde.org/r/118011/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 97424424e85404024a975b93bcbebb094c2c0350 by Cruceru Calin-Cristian to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On May 5th, 2014, 9:16 p.m. UTC, Cruceru Calin-Cristian wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<p style="color: grey;"><i>Updated May 5, 2014, 9:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The previous implementation of operator== in GeoDataPlacemark was, as even the documentation said, comparing the 2 private pointers of each instance of the class. I thought that this implementation would be more appropriate, but there are still some issues, especially caused by the m_geometry pointer:
- how should this be compared to the other's m_geometry?
- even though it is not regarded to what for I opened this bug review request, we should think of that //FIXME comment within the GeoDataPlacemark( const GeoDataPlacemark &other ) constructor because I think it will cause problems when we will finish implementing operators== and we will start testing on real .kml files.
- shouldn't m_geometry be deleted within the destructor, since its parent is the current object? I see that it is deleted when set a new one geometry, but not in destructor; maybe I didn't understand this correctly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataPlacemark.h <span style="color: grey">(bd32b4c)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPlacemark.cpp <span style="color: grey">(5df534d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118011/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>