<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117343/">https://git.reviewboard.kde.org/r/117343/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d9299ef70122fc9f6debc4d5715ac2f712cf9c79 by Dennis Nienhüser on behalf of Marek Hakala to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On April 2nd, 2014, 11:52 p.m. UTC, Marek Hakala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Dennis Nienhüser.</div>
<div>By Marek Hakala.</div>
<p style="color: grey;"><i>Updated April 2, 2014, 11:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332259">332259</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marble has KML tag handlers to parse <NetworkLinkControl> and related child tags, which are represented in a GeoDataNetworkLinkControl. Add a KML tag writer for <NetworkLinkControl> to write back the values.
- Add KmlNetworkLinkControlTagWriter.{h,cpp} to src/lib/marble/geodata/writers/kml/, implement it and add it to CMakeLists.txt in src/lib/marble/geodata/
- Add NetworkLinkControl.kml to tests/data/
See https://developers.google.com/kml/documentation/kmlreference?#networklinkcontrol for reference and examples.
Make sure to compile Marble with the following cmake options enabled: BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Execute tests/TestGeoDataWriter and make sure no errors come up. Use tools/kml2kml to analyze errors and fix the tag writers, if needed. Submit a review request at https://git.reviewboard.kde.org with the marble group as reviewers.
Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.
-----------------------------------------------------------------------------------------
List of changes:
- I added class files for NetworkLinkControl writer ( KmlNetworkLinkControlTagWriter.{cpp,h} )
- I added class files for Update writer ( KmlUpdateTagWriter.{cpp,h} )
- I added testdata file for NetworkLinkControl tag ( KML file )
- I fixed the handler for reading the NetworkLinkControl and LinkSnippet tags ( KmlNetworkLinkControlTagHandler.cpp and KmlLinkSnippetTagHandler.cpp )
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/data/NetworkLinkControl.kml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/CMakeLists.txt <span style="color: grey">(69edb65)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlLinkSnippetTagHandler.cpp <span style="color: grey">(4844490)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlNetworkLinkControlTagHandler.cpp <span style="color: grey">(3b320bb)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlNetworkLinkControlTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlNetworkLinkControlTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlUpdateTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlUpdateTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117343/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>