<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117401/">https://git.reviewboard.kde.org/r/117401/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Sanjiban Bairagya.</div>
<p style="color: grey;"><i>Updated April 9, 2014, 10:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Solved the issues in the previous revision
- Updated to current master</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333116">333116</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Added the definition for GeoDataGroundOverlay::setLatLonQuad(const GeoDataLatLonQuad& quad)
- Added operator== and operator!= to the classes GeoDataViewVolume, GeoDataVec2, GeoDataScreenOverlay, GeoDataPhotoOverlay and GeoDataGroundOverlay
- Added a protected bool equals( const GeoDataOverlay &other ) const method to GeoDataOverlay which is called in operator== of GeoDataScreenOverlay, GeoDataPhotoOverlay and GeoDataGroundOverlay to avoid redundancy.
- Extended tests/TestEquality by a new unit test method for each of the classes (except of GeoDataOverlay) which verifies the implementation for several instances of each class.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataGroundOverlay.h <span style="color: grey">(2e144af)</span></li>
<li>src/lib/marble/geodata/data/GeoDataGroundOverlay.cpp <span style="color: grey">(0a87dc4)</span></li>
<li>src/lib/marble/geodata/data/GeoDataOverlay.h <span style="color: grey">(cbfa36a)</span></li>
<li>src/lib/marble/geodata/data/GeoDataOverlay.cpp <span style="color: grey">(dd02665)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPhotoOverlay.h <span style="color: grey">(d7bae96)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPhotoOverlay.cpp <span style="color: grey">(b4baf39)</span></li>
<li>src/lib/marble/geodata/data/GeoDataScreenOverlay.h <span style="color: grey">(084fb79)</span></li>
<li>src/lib/marble/geodata/data/GeoDataScreenOverlay.cpp <span style="color: grey">(3fe3375)</span></li>
<li>src/lib/marble/geodata/data/GeoDataVec2.h <span style="color: grey">(6676281)</span></li>
<li>src/lib/marble/geodata/data/GeoDataVec2.cpp <span style="color: grey">(d27415d)</span></li>
<li>src/lib/marble/geodata/data/GeoDataViewVolume.h <span style="color: grey">(a138338)</span></li>
<li>src/lib/marble/geodata/data/GeoDataViewVolume.cpp <span style="color: grey">(0ede2a8)</span></li>
<li>tests/TestEquality.cpp <span style="color: grey">(ac5a159)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117401/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>