<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117438/">https://git.reviewboard.kde.org/r/117438/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Abhinav Gangwar.</div>
<p style="color: grey;"><i>Updated April 9, 2014, 8:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333118">333118</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Equality Operator for style related classes.
2. Added unit tests in TestEquality class to test the equality operator that have been implemented.
3. Changed TestEquality::itemIconTest() to initialize the contents of images( img1, img2 ) using 'QImage::fill( Qt::GlobalColor color )' so that
'QImage::operator==()' is able to compare images for equality. Initializing width, height and format only and keeping these parameters same for two images
isn't sufficient to make the images equal. As a result, the 'QImage::operator==()' always returns false.
4. Changed TestGeoDataCopy::copyStyleMap() so that both styleMap and testMap are of GeoDataStyleMap type object.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All tests pass on running TestEquality.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataIconStyle.h <span style="color: grey">(9a4abbf)</span></li>
<li>src/lib/marble/geodata/data/GeoDataIconStyle.cpp <span style="color: grey">(b8310cf)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLabelStyle.h <span style="color: grey">(bc161a8)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLabelStyle.cpp <span style="color: grey">(8b77188)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLineStyle.h <span style="color: grey">(6063c74)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLineStyle.cpp <span style="color: grey">(2518ab8)</span></li>
<li>src/lib/marble/geodata/data/GeoDataListStyle.h <span style="color: grey">(3d84a23)</span></li>
<li>src/lib/marble/geodata/data/GeoDataListStyle.cpp <span style="color: grey">(7418845)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPolyStyle.h <span style="color: grey">(2fe9886)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPolyStyle.cpp <span style="color: grey">(226372e)</span></li>
<li>src/lib/marble/geodata/data/GeoDataStyle.h <span style="color: grey">(2e4ccde)</span></li>
<li>src/lib/marble/geodata/data/GeoDataStyle.cpp <span style="color: grey">(da85e2d)</span></li>
<li>src/lib/marble/geodata/data/GeoDataStyleMap.h <span style="color: grey">(b81c653)</span></li>
<li>src/lib/marble/geodata/data/GeoDataStyleMap.cpp <span style="color: grey">(2e7313a)</span></li>
<li>src/lib/marble/geodata/data/GeoDataStyleSelector.h <span style="color: grey">(bf4d7ab)</span></li>
<li>src/lib/marble/geodata/data/GeoDataStyleSelector.cpp <span style="color: grey">(644158b)</span></li>
<li>tests/TestEquality.cpp <span style="color: grey">(bf4ee53)</span></li>
<li>tests/TestGeoDataCopy.cpp <span style="color: grey">(ab938b7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117438/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>