<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117459/">https://git.reviewboard.kde.org/r/117459/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice one, thanks.</pre>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On April 9th, 2014, 7:10 p.m. UTC, Marek Hakala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Dennis Nienhüser.</div>
<div>By Marek Hakala.</div>
<p style="color: grey;"><i>Updated April 9, 2014, 7:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332260">332260</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This task is about implementing full support for the KML extrude tag. It can occur as a child element of <Point>, <Polygon>, <LineString> and <LinearRing>. See https://developers.google.com/kml/documentation/kmlreference for details.
- Fix KmlextrudeTagHandler::parse, which does a faulty boolean check if( parentItem.nodeAs<GeoDataGeometry>() ). Change both checks in that area to use
parentItem.is<GeoData...>() for all fours elements (GeoDataPoint, GeoDataLineString, GeoDataLinearRing, GeoDataPolygon). Assign them the extrude value as necessary.
- Extend all Kml*TagWriter.cpp files for Point, LineString, LinearRing and Polygon to write the extrude tag if extrude is active (so either <extrude>1</extrude> ends up in the KML file or nothing).
- Extend the .kml files in tests/data/ to have at least one instance with <extrude>1</extrude> for all four tags
I fixed the reading procedure of extrude tag and extended the tests data for extrude tag. I think that the solution satisfies the task.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/handlers/kml/KmlExtrudeTagHandler.cpp <span style="color: grey">(53f1668)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlLineStringTagWriter.cpp <span style="color: grey">(6b21990)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlLinearRingTagWriter.cpp <span style="color: grey">(011fff7)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlPointTagWriter.cpp <span style="color: grey">(ebdfecd)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlPolygonTagWriter.cpp <span style="color: grey">(d190812)</span></li>
<li>tests/data/Geometries.kml <span style="color: grey">(30bfe1b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117459/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>