<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117408/">https://git.reviewboard.kde.org/r/117408/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333117">333117</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added operator== and operator!= to the classes GeoDataTimeSpan and GeoDataTimeStamp.
Changed the protected bool equals method of GeoDataObject to become virtual, and overwrote it in GeoDataAbstractView.
Made sure that TestEquality still succeeds.
Extended TestEquality by a new unit test method for GeoDataTimeSpan and GeoDataTimeStamp.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The tests are within TestEquality.cpp. I also checked the GeoDataObject::equals() functionality.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataAbstractView.h <span style="color: grey">(820354b)</span></li>
<li>src/lib/marble/geodata/data/GeoDataAbstractView.cpp <span style="color: grey">(1c00395)</span></li>
<li>src/lib/marble/geodata/data/GeoDataGeometry.h <span style="color: grey">(cf2c66f)</span></li>
<li>src/lib/marble/geodata/data/GeoDataGeometry.cpp <span style="color: grey">(094e9aa)</span></li>
<li>src/lib/marble/geodata/data/GeoDataObject.h <span style="color: grey">(b7869d4)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPoint.cpp <span style="color: grey">(20fd44b)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTimeSpan.h <span style="color: grey">(bc019fc)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTimeSpan.cpp <span style="color: grey">(4f1fbae)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTimeStamp.h <span style="color: grey">(da281b1)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTimeStamp.cpp <span style="color: grey">(e65539a)</span></li>
<li>tests/TestEquality.cpp <span style="color: grey">(bf4ee53)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117408/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>