<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117022/">https://git.reviewboard.kde.org/r/117022/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Abhinav Gangwar.</div>
<p style="color: grey;"><i>Updated March 28, 2014, 3:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed the issues with previous patch</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added support for kml schema tag and its child elements.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332334">332334</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch implements support for kml Schema tag and its child elements SimpleField and displayName</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataSchema.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSchema.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSimpleField.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSimpleField.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlDisplayNameTagHandler.cpp <span style="color: grey">(86d18e1)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlSchemaTagHandler.cpp <span style="color: grey">(c60d28c)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlSimpleFieldTagHandler.h <span style="color: grey">(1bea122)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlSimpleFieldTagHandler.cpp <span style="color: grey">(2052cc3)</span></li>
<li>src/lib/marble/geodata/parser/GeoDataTypes.h <span style="color: grey">(ae12cf1)</span></li>
<li>src/lib/marble/geodata/parser/GeoDataTypes.cpp <span style="color: grey">(a4c69e4)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlDocumentTagWriter.cpp <span style="color: grey">(d6da338)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSchemaTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSchemaTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/CMakeLists.txt <span style="color: grey">(69edb65)</span></li>
<li>src/lib/marble/geodata/data/GeoDataDocument.h <span style="color: grey">(5a36a65)</span></li>
<li>src/lib/marble/geodata/data/GeoDataDocument.cpp <span style="color: grey">(575105e)</span></li>
<li>src/lib/marble/geodata/data/GeoDataDocument_p.h <span style="color: grey">(1fd3d7d)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSimpleFieldTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlSimpleFieldTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/TestGeoDataWriter.cpp <span style="color: grey">(a8230e0)</span></li>
<li>tests/data/schema.kml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117022/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>