<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116831/">https://git.reviewboard.kde.org/r/116831/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<p style="color: grey;"><i>Updated March 17, 2014, 9:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added constructor to GeoDataAbstractView and comparison between objects' altitudeMode in GeoDataCamera::operator==.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332108">332108</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The gx:altitudeMode can now be read from and written to KML files inside the LookAt tag.
- Moved the altitudeMode getter and setter from GeoDataCamera up to GeoDataAbstractView;
- Changed KmlaltitudeModeTagHandler and KmlGxAltitudeModeTagHandler to check for GeoDataAbstractView instead of GeoDataCamera;
- Now the altitude mode in KmlLookAtTagWriter is written just like in KmlCameraTagWriter;
- Added a <gx:altitudeMode>clampToSeaFloor</gx:altitudeMode> to tests/data/LookAtTest.kml.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested it using tests/TestGeoDataWriter and it works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataAbstractView.h <span style="color: grey">(b136e4f)</span></li>
<li>src/lib/marble/geodata/data/GeoDataAbstractView.cpp <span style="color: grey">(ca44659)</span></li>
<li>src/lib/marble/geodata/data/GeoDataCamera.h <span style="color: grey">(2aa2578)</span></li>
<li>src/lib/marble/geodata/data/GeoDataCamera.cpp <span style="color: grey">(de5191d)</span></li>
<li>src/lib/marble/geodata/data/GeoDataCamera_p.h <span style="color: grey">(37ced50)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlAltitudeModeTagHandler.cpp <span style="color: grey">(2968aea)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlGxAltitudeModeTagHandler.cpp <span style="color: grey">(00785d3)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlLookAtTagWriter.cpp <span style="color: grey">(046a3cc)</span></li>
<li>tests/data/LookAtTest.kml <span style="color: grey">(60ce73c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116831/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>