<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116831/">https://git.reviewboard.kde.org/r/116831/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 16th, 2014, 11:50 a.m. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116831/diff/2/?file=254413#file254413line47" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/geodata/data/GeoDataCamera.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GeoDataCamera& GeoDataCamera::operator=( const GeoDataCamera &other )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">m_altitudeMode</span> <span class="o">==</span> <span class="n">other</span><span class="p">.</span><span class="n">d</span><span class="o">-></span><span class="n">m_altitudeMode</span><span class="p">;</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still needs to be compared for equality, and ideally our test cases would reveal this as a regression ;-)
altitudeMode() == other.altitudeMode()</pre>
</blockquote>
<p>On March 16th, 2014, 10:04 p.m. UTC, <b>Cruceru Calin-Cristian</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure what you mean by "our test cases would reveal this as a regression". Which more precisely test are you referring to?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">TestEquality::cameraTest() tests operator== of GeoDataCamera. Ideally all the equality tests would iterate over all properties of each GeoData* instance under test, assuring that == holds iff that very condition has identical values. Removing one of the conditions in operator== would then lead to the unit test to fail, revealing the problem.
</pre>
<br />
<p>- Dennis</p>
<br />
<p>On March 16th, 2014, 11:28 a.m. UTC, Cruceru Calin-Cristian wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<p style="color: grey;"><i>Updated March 16, 2014, 11:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332108">332108</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The gx:altitudeMode can now be read from and written to KML files inside the LookAt tag.
- Moved the altitudeMode getter and setter from GeoDataCamera up to GeoDataAbstractView;
- Changed KmlaltitudeModeTagHandler and KmlGxAltitudeModeTagHandler to check for GeoDataAbstractView instead of GeoDataCamera;
- Now the altitude mode in KmlLookAtTagWriter is written just like in KmlCameraTagWriter;
- Added a <gx:altitudeMode>clampToSeaFloor</gx:altitudeMode> to tests/data/LookAtTest.kml.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested it using tests/TestGeoDataWriter and it works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataAbstractView.h <span style="color: grey">(b136e4f)</span></li>
<li>src/lib/marble/geodata/data/GeoDataAbstractView.cpp <span style="color: grey">(ca44659)</span></li>
<li>src/lib/marble/geodata/data/GeoDataCamera.h <span style="color: grey">(2aa2578)</span></li>
<li>src/lib/marble/geodata/data/GeoDataCamera.cpp <span style="color: grey">(de5191d)</span></li>
<li>src/lib/marble/geodata/data/GeoDataCamera_p.h <span style="color: grey">(37ced50)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlAltitudeModeTagHandler.cpp <span style="color: grey">(2968aea)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlGxAltitudeModeTagHandler.cpp <span style="color: grey">(00785d3)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlLookAtTagWriter.cpp <span style="color: grey">(046a3cc)</span></li>
<li>tests/data/LookAtTest.kml <span style="color: grey">(60ce73c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116831/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>