<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116702/">https://git.reviewboard.kde.org/r/116702/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<p style="color: grey;"><i>Updated March 13, 2014, 6:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331532">331532</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It was intended to extend the .kml files in tests/data/ to include at least one tag for each with non-default values of BalloonStyle, ColorStyle, IconStyle, LineStyle, ListStyle, PolyStyle.
I made few modifications because most of the tags are already covered appropriately, mainly due to this bug I solved: https://bugs.kde.org/show_bug.cgi?id=331766 . This happened maybe because this is an older bug, which has been reassigned. Their coverage can be checked out here: http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/index.html .
If I misunderstood the requirements for this bug, please tell me and I will continue the work on it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've test it using tests/TestGeoDataWriter and everything works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/data/ListStyleTest1.kml <span style="color: grey">(a0fc232)</span></li>
<li>tests/data/ListStyleTest2.kml <span style="color: grey">(ce29ba2)</span></li>
<li>tests/data/MackyModel.kml <span style="color: grey">(1de8911)</span></li>
<li>tests/data/NetworkLinkDocument.kml <span style="color: grey">(0ea73d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116702/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>