<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114915/">https://git.reviewboard.kde.org/r/114915/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 8th, 2014, 11 p.m. CET, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114915/diff/2/?file=233533#file233533line464" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/eclipses/EclipsesPlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void EclipsesPlugin::writeSettings()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">457</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="n">m_reminderFacade</span><span class="o">-></span><span class="n">daysToRemind</span><span class="p">()</span> <span class="o">!=</span> <span class="n">m_settings</span><span class="p">.</span><span class="n">value</span><span class="p">(</span> <span class="s">"daysToReminds"</span> <span class="p">).</span><span class="n">toInt</span><span class="p">()</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Aren't such checks the duty of the respective setter (if needed at all)?</pre>
</blockquote>
<p>On March 7th, 2014, 12:11 a.m. CET, <b>Marek Hakala</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would say that it is not necessary. I tried to keep code style by previous work.</pre>
</blockquote>
<p>On March 7th, 2014, 9:57 a.m. CET, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the checks are not necessary then just remove them, please.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I'll do it.</pre>
<br />
<p>- Marek</p>
<br />
<p>On March 7th, 2014, 12:08 a.m. CET, Marek Hakala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Torsten Rahn and René Küttner.</div>
<div>By Marek Hakala.</div>
<p style="color: grey;"><i>Updated March 7, 2014, 12:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">
Task:
Implement the reminder functionality. There already is a reminder option in the preferences dialog and a user interface for the reminder dialog (EclipsesReminderDialog.ui). However, these are not implemented yet. You could implement the code that reminds the user if an eclipse event occours within the next week and show the dialog. It would also be nice if the user could jump to the eclipse event from the reminder dialog. We also have to make sure the dialog does not appear again and again. The dialog itself should show some information about the event (type, date, time, length etc.)
Solution:
In this task I implemented the filter model and application logic for reminder by the QT's Model/View patterns. I added the facade class for reminder management. This patch adds the ability for remind eclises events in adjustable time period.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/astro/eclsolar.h <span style="color: grey">(5eb567c)</span></li>
<li>src/lib/astro/eclsolar.cpp <span style="color: grey">(ac0aa61)</span></li>
<li>src/plugins/render/eclipses/CMakeLists.txt <span style="color: grey">(f650e08)</span></li>
<li>src/plugins/render/eclipses/EclipsesConfigDialog.ui <span style="color: grey">(ca25e6f)</span></li>
<li>src/plugins/render/eclipses/EclipsesFilterProxyModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesFilterProxyModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesItem.h <span style="color: grey">(cc971e9)</span></li>
<li>src/plugins/render/eclipses/EclipsesItem.cpp <span style="color: grey">(0148780)</span></li>
<li>src/plugins/render/eclipses/EclipsesModel.h <span style="color: grey">(5196d8d)</span></li>
<li>src/plugins/render/eclipses/EclipsesModel.cpp <span style="color: grey">(0c251a7)</span></li>
<li>src/plugins/render/eclipses/EclipsesPlugin.h <span style="color: grey">(5484292)</span></li>
<li>src/plugins/render/eclipses/EclipsesPlugin.cpp <span style="color: grey">(e20e900)</span></li>
<li>src/plugins/render/eclipses/EclipsesReminderDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesReminderDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesReminderDialog.ui <span style="color: grey">(5d17519)</span></li>
<li>src/plugins/render/eclipses/EclipsesReminderFacade.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/eclipses/EclipsesReminderFacade.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114915/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>