<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116644/">https://git.reviewboard.kde.org/r/116644/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit dd619961e97e926a02d4cb0d5cfa6a11d81fa362 by Dennis Nienhüser on behalf of Cruceru Calin-Cristian to branch master.</pre>
 <br />









<p>- Commit Hook</p>


<br />
<p>On March 7th, 2014, 9:11 p.m. UTC, Cruceru Calin-Cristian wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>


<p style="color: grey;"><i>Updated March 7, 2014, 9:11 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=331766">331766</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extends the existing .kml unit tests in tests/data and also adds new ones to maximize the test coverage of tag writers.

There is one mention: The test, tests/TestGeoDataWriter fails because of the file tests/data/Tour.kml and I have the following diff: http://paste.kde.org/pksuar839 . I cannot figure out at the moment why it jumps over this tag. Syntactically, my .kml file seems correct, so I think there is a problem in the code ? I will try to find what causes this and I will come back with an update if necessary.</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tests/data/CameraLookAt.kml <span style="color: grey">(8934073)</span></li>

 <li>tests/data/AltitudeMode.kml <span style="color: grey">(0e90594)</span></li>

 <li>tests/data/CDATATest.kml <span style="color: grey">(a14931e)</span></li>

 <li>src/lib/marble/geodata/handlers/kml/KmlFlyToModeTagHandler.cpp <span style="color: grey">(b993d7e)</span></li>

 <li>tests/data/Geometries.kml <span style="color: grey">(eff3bb1)</span></li>

 <li>tests/data/ListStyleTest1.kml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/data/ListStyleTest2.kml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/data/ListStyleTest3.kml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/data/ListStyleTest4.kml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/data/ListStyleTest5.kml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/data/LookAtTest.kml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/data/PhotoOverlayInFolder.kml <span style="color: grey">(ec4bb3f)</span></li>

 <li>tests/data/Tour.kml <span style="color: grey">(0f2c044)</span></li>

 <li>tests/data/Track.kml <span style="color: grey">(2ac0a6e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116644/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>