<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116553/">https://git.reviewboard.kde.org/r/116553/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<p style="color: grey;"><i>Updated March 5, 2014, 5:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331672">331672</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a protected method bool equals(GeoDataGeometry &other) const; to GeoDataGeometry and makes possible to check for equality using operator== for the classes mentioned in the Summary.
Also added a testing function for each of the classes in tests/TestEquality.cpp and it passes all the tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As I said above, I tested it using TestEquality and it works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataGeometry.h <span style="color: grey">(0212a45)</span></li>
<li>src/lib/marble/geodata/data/GeoDataGeometry.cpp <span style="color: grey">(c09ba04)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLineString.h <span style="color: grey">(b86fa07)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLineString.cpp <span style="color: grey">(3b60ed2)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLinearRing.h <span style="color: grey">(644dfd7)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLinearRing.cpp <span style="color: grey">(b4fa3f5)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPoint.h <span style="color: grey">(1a61ca8)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPoint.cpp <span style="color: grey">(aa595c0)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPolygon.h <span style="color: grey">(c7071bf)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPolygon.cpp <span style="color: grey">(5007ab9)</span></li>
<li>tests/TestEquality.cpp <span style="color: grey">(d32a771)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116553/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>