<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116059/">https://git.reviewboard.kde.org/r/116059/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 137f5d45661cb9524805a0fc336a74924afc812d by Dennis Nienhüser on behalf of Cruceru Calin-Cristian to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On February 28th, 2014, 10:20 p.m. UTC, Cruceru Calin-Cristian wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2014, 10:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331467">331467</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extend KmlPhotoOverlayWriter.cpp to also write the following elements (and their children): - rotation - ViewVolume - ImagePyramid - shape
I fail the test with tests/TestGeoDataWriter so I'm waiting for review with what I'm doing wrong.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/writers/kml/KmlPhotoOverlayWriter.cpp <span style="color: grey">(5903654)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(198c6c3)</span></li>
<li>tests/TestGeoDataWriter.cpp <span style="color: grey">(45e6321)</span></li>
<li>tests/TestPhotoOverlay.cpp <span style="color: grey">(f4d8b32)</span></li>
<li>tests/data/PhotoOverlayAsRoot.kml <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/data/PhotoOverlayInFolder.kml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116059/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/02/25/091ac6a9-8b67-434a-a678-d15a7d87f4c5__0002-Update.patch">The testing file</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>